You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Can you please tell me, @waynevanson, what the intention was?
Not being a Nodejs developer, I still love to use npm to pull dependencies into my C# ASP.NET Core project. Your intended change makes life more difficult now.
@bytestream theres no real reason. Do you have a reason for needing it? Files are minified for production, so I don't think it makes much of a difference leaving it out.
The reasoning behind some of these accidental changes are that were trying to get typescript compiling with tools that we can manage in the future. Before we had no typescript in the code base.
@UweKeim i didn't realise users would be importing it from sortablejs/Sortable.
I'll try add it back.
Reacted by Uwe Keim, Jay and Loïc Boursin
Reacted by Uwe Keim, Zhiyuan Chen and Loïc Boursin
Hi @waynevanson ! I'm in the same boat! I use yarn for dependencies management but I'm not using a module bundler to pack my javascript, just Rails with the good old asset pipeline. So for all of us working on "legacy" projects, having a precompiled version of sortable.js is really useful. Would be great if you could add it back or else I'll just stick with version 1.10.2.
@waynevanson The Rails asset pipeline has its own minifier so for my use case the non-minified sortablejs/Sortable.js would be enough. But it could be either one, as long as it doesn't require a module bundler such as Webpack to be usable.
Activity
HopeMa commentedon Sep 22, 2020
why？
There is a problem with the project，now
Module not found: Error: Cannot resolve module 'sortablejs/Sortable'
yougene commentedon Sep 22, 2020
hey!
just updated some modules and stumbled about this too.
I fixed it by adding the import as a module relative to your path:
Then you can use Sortable.create(whatever.... again.
Hope this helps!
waynevanson commentedon Sep 22, 2020
The change was intended.
@HopeMa Are you importing
sortablejs/Sortable? Importsortablejsinstead.@yougene did
import Sortable from 'sortablejs'not work for you?bytestream commentedon Sep 22, 2020
@waynevanson presumably
dist/sortable.umd.jsis the same asSortable.min.jsin 1.10.2?What's the reason for not including an unminified file like before?
yougene commentedon Sep 22, 2020
I tried that, but e.g. Firefox gives me:
Uncaught SyntaxError: import declarations may only appear at top level of a moduleI'm currtently just doing some flat layouting with Bulma, so this was a quick workaround.
UweKeim commentedon Sep 22, 2020
Stumbled over this, too.
Using the node module only to get "sortable.js" into my ASP.NET Core project via gulpfile.js.
UweKeim commentedon Sep 22, 2020
Can you please tell me, @waynevanson, what the intention was?
Not being a Nodejs developer, I still love to use npm to pull dependencies into my C# ASP.NET Core project. Your intended change makes life more difficult now.
waynevanson commentedon Sep 23, 2020
@bytestream theres no real reason. Do you have a reason for needing it? Files are minified for production, so I don't think it makes much of a difference leaving it out.
The reasoning behind some of these accidental changes are that were trying to get typescript compiling with tools that we can manage in the future. Before we had no typescript in the code base.
@UweKeim i didn't realise users would be importing it from
sortablejs/Sortable.I'll try add it back.
bytestream commentedon Sep 23, 2020
I was using in gulpjs to concatenate and minify multiple library files.
pomartel commentedon Sep 24, 2020
Hi @waynevanson ! I'm in the same boat! I use yarn for dependencies management but I'm not using a module bundler to pack my javascript, just Rails with the good old asset pipeline. So for all of us working on "legacy" projects, having a precompiled version of sortable.js is really useful. Would be great if you could add it back or else I'll just stick with version 1.10.2.
[-]version 1.12.0 remove Sortable.js file[/-][+]Restore sortable/Sortable.js[/+]waynevanson commentedon Sep 25, 2020
@pomartel Which file are you after? The non minified version that is
sortablejs/Sortable.js?UweKeim commentedon Sep 25, 2020
Usually both: using the non-minified in debug builds and the minified in release builds.
pomartel commentedon Sep 25, 2020
@waynevanson The Rails asset pipeline has its own minifier so for my use case the non-minified
sortablejs/Sortable.jswould be enough. But it could be either one, as long as it doesn't require a module bundler such as Webpack to be usable.