Repository navigation
Navigation was not working on storage containers the correct view wasn't shown - #776
Open
SharonStrats wants to merge 2 commits into
Open
SharonStrats wants to merge 2 commits into
SharonStrats wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Storage detection misses viewer-declared roots, and layout selection can remain stale after authentication completes.
2 open issues
What changed in this PR
This PR makes storage navigation choose an explicit folder layout based on ownership and navigation source. It also enables friend actions in compact Friends-tab headings.
Changes:
- Detect storage roots during navigation and pass folder-view options through the outline.
- Adjust resource-header visibility for storage layouts.
- Update friend-action rendering and add regression tests.
| File | Description |
|---|---|
test/unit/navigation/storagePane.test.ts |
Tests forwarding folder-view options. |
test/unit/navigation/controller.test.ts |
Covers storage layouts and root restoration. |
test/unit/navigation/chrome.test.ts |
Tests storage layouts, headers, and friend-action eligibility. |
test/unit/mainPage/profileHeadingFriends.test.ts |
Covers friend actions in compact headings and Friends tabs. |
test/unit/mainPage/index.test.ts |
Updates account-menu navigation expectations. |
src/outline/manager.js |
Forwards folder-view options and adjusts header/index handling. |
src/navigation/options.ts |
Defines folder-view options and their resolver. |
src/navigation/controller.ts |
Detects storage roots and selects their layout. |
src/navigation/chrome.ts |
Adds storage-layout and friend-action rules. |
src/mainPage/profileHeading.ts |
Enables friend actions on Friends tabs. |
src/components/profile-heading/ProfileHeading.ts |
Shows compact friend actions while hiding Edit. |
src/components/profile-heading/ProfileHeading.styles.css |
Aligns compact heading actions. |
Review effort: Balanced
…did not appear on compact profile header Prompt: when the user is on their "storage" container the full view of folder pane should appear, the storage in navbar should show the sidebar and the content no folder pane header. Co-authored-by: ClaudeOpus 5.5 <ClaudeOpus5.5@openai.com>
SharonStrats
force-pushed
the
fix/navigation-views
branch
from
October 25, 2026 00:52
06d93aa to
545006f
Compare
…@5.0.2-3 pane-registry@5.0.2-1 folder-pane@4.0.1-0 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Navigation was not working on storage containers the correct view wasn't shown.
Here is a document describing our desired behavior Navigation Testing Scenarios