Repository navigation
Clear omitted props in React remote components - #737
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
Author
|
I have signed the CLA. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The layout effect in
createRemoteComponent()(@remote-dom/react) iterates only over the props of the current render. A prop that was passed in the previous render and is omitted from the next one is never visited, so the remote element keeps the stale attribute, property, oreventPropslistener. The host keeps rendering the old value, and a removed listener keeps firing.This change iterates over the union of the current and previous prop names. An omitted prop is handled like a prop set to
undefined: the attribute is removed, the property is set toundefined, and theeventPropslistener is removed.Tests
clears props that are omitted when a remote React component re-renderstopackages/react/source/tests/e2e.test.tsx. The test renders aRemoteButtonwithtooltip,disabled, andonPress, re-renders it without them, and checks the remote element, the host props, and thatpressno longer calls the removed handler.tooltipattribute is still present. With the change, it passes.pnpm test(67 files, 1102 tests),pnpm lint,pnpm type-check, andpnpm sizepass.Adds a patch changeset for
@remote-dom/react.Fixes #736