Repository navigation
Conversation
RemoteElement stored listener records in a per-element map keyed only by the listener, so adding the same listener for a second remote event replaced the record for the first one. Removing it afterwards never told the host, which kept both event listeners registered. Track listener records on each event record instead.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
RemoteElementkeeps one listener record per element in a map keyed only by the listener. When the same listener is added for two remote events, the secondaddEventListener()call replaces the record for the first event:On
main, the host keeps bothpressandhoverin the element'seventListenersafter both calls. The first removal reads thehoverrecord, so no update is sent forpress, and it deletes the shared map entry, so the second removal finds no record and returns early.Change
Store listener records on each event record (
remoteEvent.listenersis now aMapinstead of aSet) and look them up by event type inremoveEventListener(). The per-element listener map is no longer needed and is removed.Tests
Added a test in
packages/core/source/tests/elements.test.tsthat adds one listener for two events, removes it from each, and expects an event listener update for each event. It fails onmainand passes with this change.Ran
pnpm test(all passing exceptprepare-wpt.test.ts, which also fails onmainon Windows with anEPERMrename error),pnpm type-check,pnpm lint, and the@remote-dom/corebuild. Added a patch changeset for@remote-dom/core.