[HarryCordewener]

Requested by Grave · project thread

Phase 0 of the implementation plan. This PR changes only the version, and nothing else is in it. If the new parser causes a regression, it can only come from this change.

What changed

• TelnetNegotiationCore 2.12.0 → 4.5.2.
• Microsoft.Extensions.Logging.Abstractions 10.0.2 → 10.0.13, because 4.5.2 depends on that patch and NU1605 treated the downgrade as an error.
• CLAUDE.md now has a paragraph on what the version jump changed and what it makes available.

Why no source change

• The 4.0 generated parser, the 3.0 removal of OneOf and the 4.1.1 rule that a duplicate plugin throws do not touch anything this repo calls. EOR, SGA and PacketPatch are three separate plugins, each registered once.
• CallbackOnByteAsync is still init-only and CurrentEncoding still has an internal set, so both reflective reaches in TelnetSession still work. NAWSProtocol is still public and non-sealed.

Verification

• dotnet build SharpMUTerm.slnx -c Release: 0 warnings, 0 errors.
• Graphics 99/99, Scripting 42/42, Web 37/37, Tui 1956/1956, Avalonia 191/191.
• Core 1112/1113. The one failure is ScrollbackSpillTests.AReadOnlyCacheDirectory_DegradesToMemoryOnly. It fails because this sandbox runs as root, which ignores the read-only bit; it is unrelated to this change.
• UnsolicitedNegotiationTests and the prompt tests (GA, EOR, packet-patch silence) pass unchanged.
• Not done: a session against a live server. This sandbox cannot open raw TCP. Please connect to one MCCP server, one MXP server and one GA-only server before merging.

Changelog

None, because a player sees no change. This needs the skip-changelog label.

---

Generated by Claude Code

[coderabbitai]

Warning

Review limit reached

• Run on-demand review

_{This review includes 2 billable files and costs up to $0.50.}

• Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 59 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 64 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Essentials
• Run ID: 9df77107-9907-445e-abe7-4887b5806080

Commits

Reviewing files that changed from the base of the PR and between 63e9bbe and d0e9d33.

Files selected for processing: 2

• CLAUDE.md
• Directory.Packages.props

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}