Repository navigation
Implement new D2D1 transform mapper infrastructure - #432
Merged
Merged
Conversation
Sergio0694
added
enhancement ✨
Sergio0694
force-pushed
the
dev/d2d-custom-transforms
branch
2 times, most recently
from
November 24, 2022 22:10
8c79a17 to
f764b6a
Compare
Sergio0694
marked this pull request as ready for review
November 24, 2022 22:11
rickbrew
requested changes
Nov 27, 2022
rickbrew
left a comment
rickbrew
left a comment
Collaborator
There was a problem hiding this comment.
Alright, found some things you should look at and maybe fix. Also, consider adding some transform mapper unit tests that use something with an infinite output rect, e.g. Flood effect
Sergio0694
force-pushed
the
dev/d2d-custom-transforms
branch
from
November 29, 2022 21:05
ceb6ae8 to
6feca74
Compare
Sergio0694
force-pushed
the
dev/d2d-custom-transforms
branch
from
November 29, 2022 21:34
27987ef to
a9edecf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #420
Description
This PR implements all changes outlined in the linked PR.