Repository navigation
Accept the exact H2 header-list limit - #153
Merged
Merged
Conversation
29 of 42 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SETTINGS_MAX_HEADER_LIST_SIZEas an inclusive maximumh2 0.4.16+monad.2and update its diff inventoryRationale
MONAD advertises a 32 KiB maximum and the protocol permits lists within that value. Vendored upstream H2 used
>=when marking a decoded list oversized, so an exactly 32,768-byte list was incorrectly rejected. Increasing the configured value would advertise the wrong limit; this instead fixes the decoder comparison.Verification
cargo test --manifest-path vendor/h2/Cargo.toml frame::headers::testcargo test --manifest-path vendor/h2/Cargo.toml --test paused_flow_controlmonad-commonclient/server boundary testscargo testmake lintmake stress-tinygit diff --check