Repository navigation
Add pull-request CI (Foreman, tools, mod + game tests) - #3
Merged
Merged
Conversation
Runs npm run check on Node 22.18 and 24, the tools tests, and the mod build plus Fabric game tests once the gametest source set exists (MP-T). Nothing is published. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012rNg9gkomRvRWZ23oM7NVX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/workflows/ci.yml, to land before MP-T (#1) and MP-B (#2) merge so both are validated by CI.npm ci && npm run check(typecheck, vitest, protocol-doc freshness) on Node 22.18 (new minimum) and 24.npm test --prefix toolson Node 22.18../gradlew build, then./gradlew runGameTestwhenmod/src/gametest/**exists (it appears with MP-T).Read-only permissions, actions pinned by SHA, runs on PRs to
main, pushes tomainand manual dispatch. Nothing is published.Expected on this PR: the Node 24 Foreman leg may fail on
mainas-is. That is theparseTestOutputbug MP-B fixes (481/482 on Node 24), so after merging this, #2 should turn it green. #1 and #2 need a rebase or re-run after this merges to pick up the workflow.🤖 Generated with Claude Code
https://claude.ai/code/session_012rNg9gkomRvRWZ23oM7NVX