Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixing an unbounded mono source into stereo can overflow in ChannelCountConverter::size_hint. Large finite hints can overflow there too, causing a debug panic or a wrapped hint in release builds.
Saturate the lower-bound arithmetic and return no upper bound when that calculation overflows. Finite hints that fit keep their existing values. Added regressions through the public mixer and channel converter for unbounded sources, different channel ratios and an oversized finite upper bound.
All three regressions fail before the fix and pass in debug and release after it. The default-feature integration/unit tests and the no-default-feature suite, including doctests, pass. Formatting and strict Clippy for the library and new tests pass. Full all-target Clippy on Rust 1.99 reports two existing chunks_exact warnings in tests/seek.rs.
Fixes #935.