Repository navigation
Fix missing \n in printing calls such as pr_*! and dev_*! #1139
Description
Fix missing \n in printing calls such as pr_*! and dev_*!.
For instance, there are:
- Four instances in
samples/rust/rust_print_main.rsthat should be fixed in a single patch targeting the "RUST" subsystem in theMAINTAINERSfile. - One instance in
samples/rust/rust_dma.rsthat should target the "DMA MAPPING & SCATTERLIST API [RUST]" in a different patch.
There are others outside rust/ and some may appear new from time to time, see e.g. https://lore.kernel.org/rust-for-linux/f4d26971-bf10-4370-8994-13ad962becfd@nvidia.com/ for a search done in January 2026.
[ Finally, but separate to this issue, you may consider reviewing/testing/... to help revive this patch to warn about new instances in scripts/checkpatch.pl: https://lore.kernel.org/rust-for-linux/20250207-checkpatch-newline2-v4-1-26d8e80d0059@invicto.ai/ (issue #1140 ). ]
This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Suggested-by: tag, a Link: tag to this issue and a Fixes: tag to the relevant commit. Please see https://docs.kernel.org/process/submitting-patches.html and https://rust-for-linux.com/contributing for details.
Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel. Please do not take it if you do not plan to make other contributions to the kernel.
Activity
albankurti commentedon Feb 3, 2025
First time looking at issues for the project, but I wasn't able to find any missing \n in any printing calls other than in the documentation examples, I looked at the rust/ directory, am I missing something?
charmitro commentedon Feb 3, 2025
@albankurti also check the samples directory,
samples/rust/*.rs.albankurti commentedon Feb 3, 2025
Emailed fix for what I found in samples/
rust: docs: add missing newline to printing macro examples
rust: error: add missing newline to pr_warn! calls
rust: init: add missing newline to pr_info! calls
rust: sync: add missing newline in locked_by log example
rust: workqueue: add missing newline to pr_info! examples
rust: samples: add missing newline to pr_info! calls in rust_print_main
rust: docs: add missing newline to printing macro examples
rust: error: add missing newline to pr_warn! calls
rust: init: add missing newline to pr_info! calls
58 remaining items
rust: init: add missing newline to pr_info! calls
rust: module_param: add missing newline to pr_warn_once
rust: module_param: add missing newline to pr_warn_once
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main
rust: samples: add missing newlines in rust_print_main