Skip to content

Make from_errno use try_from_errno #1125

New issue
New issue
Open
Open
Make from_errno use try_from_errno#1125
Labels
easyExpected to be an easy issue to resolve.good first issueGood for newcomers• libRelated to the `rust/` library.

Description

@ojeda
ojeda
opened on Oct 7, 2024

Make from_errno use try_from_errno (available in rust-next).

This also allows to remove unsafe code and a comment or two too.

This requires submitting a proper patch to the LKML and the Rust for Linux mailing list. Please recall to test your changes (including generating the documentation if changed, running the Rust doctests if changed, etc.), to use a proper title for the commit, to sign your commit under the Developer's Certificate of Origin and to add a Suggested-by: tag and a Link: tag to this issue. Please see https://rust-for-linux.com/contributing for details.

Please take this issue only if you are new to the kernel development process and you would like to use it as a test to submit your first patch to the kernel. Please do not take it if you do not plan to make other contributions to the kernel.

Activity

  1. ojeda
    added
    good first issueGood for newcomers
    easyExpected to be an easy issue to resolve.
    on Oct 7, 2024

  2. cristiangabor commented on Oct 8, 2024

    @cristiangabor
    cristiangabor
    on Oct 8, 2024

    I am new to the Kernel development process and I would like to participate if is possible.

  3. ojeda commented on Oct 8, 2024

    @ojeda
    ojeda
    on Oct 8, 2024
    MemberAuthor

    Sure, please go ahead!

  4. oddgarden6465 commented on Nov 4, 2024

    @oddgarden6465
    oddgarden6465
    on Nov 4, 2024

    Hello, is this issue still available ? I would like to participate if possible.

  5. ojeda commented on Nov 4, 2024

    @ojeda
    ojeda
    on Nov 4, 2024
    MemberAuthor

    I think we didn't get a patch from @cristiangabor yet -- Cristian, do you plan to send it? Thanks!

  6. cristiangabor commented on Nov 4, 2024

    @cristiangabor
    cristiangabor
    on Nov 4, 2024

    Unfortunately I did not made the fix. @haveheartt please go ahead with the implementation!

  7. ojeda commented on Nov 5, 2024

    @ojeda
    ojeda
    on Nov 5, 2024
    MemberAuthor

    https://lore.kernel.org/rust-for-linux/20241104185135.18974-1-daniel@sedlak.dev/
    https://lore.kernel.org/rust-for-linux/20241104200014.12996-1-guilhermev2huehue@gmail.com/
    https://lore.kernel.org/rust-for-linux/20241105114819.14051-1-guilhermev2huehue@gmail.com/

  8. intel-lab-lkp
    added a commit that references this issue on Nov 25, 2024

    rust: error: modify `from_errno` to use `try_from_errno`

    35b5c7d
  9. ojeda
    added
    • libRelated to the `rust/` library.
    on Nov 25, 2024
  10. intel-lab-lkp
    added a commit that references this issue on Dec 7, 2024

    rust: error: modify `from_errno` to use `try_from_errno`

    74f2726
  11. ojeda
    added a commit that references this issue on Dec 17, 2024

    rust: error: modify `from_errno` to use `try_from_errno`

    9a02cbc
  12. senekor
    added a commit that references this issue on Feb 15, 2025

    rust: error: modify `from_errno` to use `try_from_errno`

    42cdb29
  13. jannau
    added a commit that references this issue on Mar 1, 2025

    rust: error: modify `from_errno` to use `try_from_errno`

    3f7cbe8
  14. dylanmtaylor
    added a commit that references this issue on Mar 28, 2025

    rust: error: modify `from_errno` to use `try_from_errno`

    e1ecc1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    easyExpected to be an easy issue to resolve.good first issueGood for newcomers• libRelated to the `rust/` library.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions