Repository navigation
Conversation
eddyb
added this pull request to stack #685
October 15, 2026 23:08
…PointerINTEL` support.
eddyb
force-pushed
the
eddyb/spirt-0.5.0
branch
from
October 16, 2026 11:47
0cb1693 to
6537c00
Compare
Thanks! I rebased on top of this branch and it works 🎉 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will stay as draft until
spirt 0.5.0is released, containing at least:ControlRegionto justRegion. spirt#7ControlNodeto justNode. spirt#8Attr::SpvDebugLinewith a better basic debug source location attribute. spirt#9DataInstForm(inlining its fields back intoDataInstDef). spirt#12SPIRV-Headersto match Vulkan SDK 1.4.363.0. spirt#49rspirv(see Regenerate onvulkan-sdk-1.4.363.0gfx-rs/rspirv#280),so that
spirtwill (hopefully) not block the use of newer extensionsOpSpecConstantOpandOpConstantFunctionPointerINTELsupport. spirt#22if-else/switch, as allowed by SPIR-V. spirt#28This came about because of
OpExecutionModeId/FPFastMathDefault, wanted by:(cc @jlogan03, you might be able to test by rebasing on top of this branch)
FPFastMathDefaulttakes:Type-in-Constembedding that other extensions also ended up needing independently (e.g.OpUntypedPtrAccessChainKHR)And any IDs being involved meant
spirt::Attr::SpvAnnotationhas to grow an extra field (which is even worse than just someConsts, because of howAttrSetrelies onAttr: Ordetc.).Hopefully the solution will cover anything else Rust-GPU may need for the next little while.