Skip to content

Extract addUserToRoom/removeUserFromRoom logic to separate function that doesn't require logged in user #454

Closed

Description

@rwakida

Use Case:
Allows automated, anonymous (bot) adding/removal of users from a room. For example, we create a channel based on a user's location, and automatically add the user to the channel.

The logic to update the ChatRoom/ChatSubscription, and create a new ChatMessage would be extracted to a new non-exposed, serverside function. The existing Method methods would check that Meteor.userId() exists, and that the current user created the room then delegates to the new methods. The backend "bots" would call the extracted method.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

Activity

  1. engelgabriel commented on Aug 14, 2015

    @engelgabriel
    Member

    Agreed! We did something similar with sendMessage.. we should do the same with ALL methods.

  2. modified the milestone: on Aug 15, 2015
  3. modified the milestones: , on Sep 21, 2015
  4. modified the milestones: , on Feb 23, 2016
  5. geekgonecrazy commented on May 12, 2016

    @geekgonecrazy
    Contributor

    With our bots now being logged in, and having our permissions system in place. Is this still relevant?

  6. rwakida commented on May 12, 2016

    @rwakida
    ContributorAuthor

    @geekgonecrazy I haven't kept up with the RocketChat changes, but I'm cool with closing this issue as long as bots can execute the function. This also applies to issue #455.

  7. engelgabriel commented on May 12, 2016

    @engelgabriel
    Member

    I don't think we should close it. We still need to move all logic from all methods into internal functions. Maybe we can re-title it?

  8. graywolf336 commented on Dec 7, 2016

    @graywolf336
    Contributor

    @engelgabriel Most of the requirements of the original request are now implemented and can be accessed in many ways, either the rest api or ddp method calls. Can this be closed now?

  9. modified the milestones: 0.48.0, on Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions