Skip to content

Avoid accessing the https metadata server endpoint - #1471

Merged
douglasjacobsen merged 1 commit into
Ramble-Project:developfrom
linsword13:fix-gcs-fetch
Mar 26, 2026
Merged

douglasjacobsen merged 1 commit into
Ramble-Project:developfrom
linsword13:fix-gcs-fetch

Conversation

@linsword13

Copy link
Copy Markdown
Collaborator

For newer releases of google-auth lib, it attempts to connect using mTLS when it can find the certs in well-known locations. This causes our fetcher to fail with cert error. The mTLS change was introduced by googleapis/google-auth-library-python#1856.

We probably need to upstream this to Spack as well.

For newer releases of `google-auth` lib, it attempts to connect using mTLS when it can find the certs in well-known locations. This causes our fetcher to fail with cert error. The mTLS change was introduced by googleapis/google-auth-library-python#1856.

We probably need to upstream this to Spack as well.
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a critical workaround to address certificate errors that occur when the google-auth library, in its newer versions, attempts to establish mTLS connections to the GCE metadata server on Google Cloud Platform virtual machines. By explicitly disabling mTLS for this specific interaction, the change ensures smooth authentication and prevents connection failures caused by the library's updated behavior.

Highlights

  • GCE mTLS Workaround: Disabled GCE mTLS for the metadata server by setting the GCE_METADATA_MTLS_MODE environment variable to "none". This resolves certificate errors encountered with newer google-auth library versions on certain GCP VMs, which attempt mTLS connections when certificates are found in well-known locations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a workaround for google-auth mTLS certificate errors on GCP VMs by setting the GCE_METADATA_MTLS_MODE environment variable to "none". A review comment suggests condensing the explanatory comment for improved readability.

Comment thread lib/ramble/spack/util/gcs.py Resolved
@douglasjacobsen
douglasjacobsen merged commit 0b4a9fc into Ramble-Project:develop Mar 26, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants