Repository navigation
Avoid accessing the https metadata server endpoint - #1471
Conversation
For newer releases of `google-auth` lib, it attempts to connect using mTLS when it can find the certs in well-known locations. This causes our fetcher to fail with cert error. The mTLS change was introduced by googleapis/google-auth-library-python#1856. We probably need to upstream this to Spack as well.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a critical workaround to address certificate errors that occur when the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a workaround for google-auth mTLS certificate errors on GCP VMs by setting the GCE_METADATA_MTLS_MODE environment variable to "none". A review comment suggests condensing the explanatory comment for improved readability.
For newer releases of
google-authlib, it attempts to connect using mTLS when it can find the certs in well-known locations. This causes our fetcher to fail with cert error. The mTLS change was introduced by googleapis/google-auth-library-python#1856.We probably need to upstream this to Spack as well.