Repository navigation
Fix OS command injection via workflow OCR language settings (CWE-78) … - #393
Merged
R0Wi merged 1 commit intoAug 19, 2026
Merged
Conversation
…391) * Fix OS command injection via workflow OCR language settings (CWE-78) WorkflowSettings.languages was validated with is_array() only. Its elements were concatenated unescaped into the ocrmypdf command line (CommandLineUtils::getCommandlineArgs), which is executed as a raw shell string via mikehaertl/php-shellcommand's proc_open(). Unlike customCliArgs, languages was never passed through the ';'/'&&' stripping applied by escapeCustomCliArgs(), so any authenticated user able to create a personal workflow (workflowengine API, the web server user once a matching file was processed. Fix, in two layers: - WorkflowSettings now validates every language value against an allow-list pattern for tesseract/ocrmypdf language codes (letters/digits/underscore/slash, e.g. 'eng', 'chi_sim', 'script/Latin'); an invalid array is rejected like any other malformed field, so a workflow with a malicious language value cannot be saved. - CommandLineUtils applies the same allow-list again immediately before building the command line, filtering out and logging any value that doesn't match, as defense in depth for workflows stored before this fix. Adds regression tests covering shell-metacharacter payloads (';', '&&', '|', '$()', backticks) for both layers. Reported by Duc Anh Nguyen (@gladiator9797). * fix(ci): Remove autoload-dev from composer to get rid of OCP signature errors because of stale Nextcloud OCP composer package --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #391 to
stable33