Repository navigation
panic on attach if interpreter is shutting down - #5317
Merged
Merged
Conversation
CodSpeed Performance ReportMerging #5317 will not alter performanceComparing Summary
|
Icxolu
approved these changes
Aug 20, 2025
davidhewitt
enabled auto-merge
August 20, 2025 20:13
Member
Author
|
Thanks for the review! FYI I'm just drafting a follow up to expose |
Merged
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to solve the build failure seen in #5309 (at least locally, it seems to be good enough).
The problem is that the test added in #4874 which repeatedly calls
Python::attachto try to hit the "hang thread" case seems to just cause Python 3.14 to segfault. The docs explicitly say this might happen if you callPyGILState_Ensureduring finalization, to be fair.To try to avoid that crash, this adds the FFI definition
Py_IsFinalizing(available on 3.13 and up) and uses that to try a best-effort panic instead of segfault. As a follow-up I'll probably exposePython::try_attachand change the test to use it, to avoid a slightly messy panic at the end of the test suite.While adding
Py_IsFinalizingI synced thepylifecycledefinitions and corrected a few other cases.