Repository navigation
Wheel test: check the GIL only on free-threaded builds - #38
Merged
Merged
Conversation
9.5.51's publish failed at every wheel's test: the GIL check also ran on regular builds, where the GIL is always on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
9.5.51's publish failed at every wheel's test (
AssertionError: importing lvgl enabled the GIL): the check added in #37 also ran on regular builds, where the GIL is always on. The check now applies only wheresysconfig.get_config_var('Py_GIL_DISABLED')is set. Free-threaded builds still fail if importing lvgl turns the GIL back on.Before merging, a temporary workflow (since removed) ran the release's own cibuildwheel test on cp313, cp315 and cp315t, on Linux and Windows. All six built and passed, and the cp315t wheels passed the GIL-off check.