Repository navigation
Sync bindings d0f6f4f: callback trampolines hold their callback and release their arguments - #36
Merged
Merged
Conversation
…elease their arguments A callback that replaced its own registration while it ran was freed mid-call, and every callback call leaked a reference to each argument. tests/test_callback_references.py covers both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncs generated/lvgl_python.c from PyDevices/lvgl-bindings#35 (
d0f6f4f). Two fixes for every LVGL callback that calls into Python:timer.set_cb(other)from inside the timer callback used to drop the only reference to the running callback.tree_walkcallback was never freed.tests/test_callback_references.pychecks both in a subprocess underMALLOC_PERTURB_. Against the bindings before this sync it fails both ways: the callback is dead after replacing itself, and a widget's reference count is up by 10 after 10 tree walks. With this sync it passes, as do the full suite (30 tests) and lvgl-bindings'tools/test_lvgl_smoke.py.This relies on #35:
mp_lv_funcptrnow returns a new reference, like every other converter the trampolines release.