Skip to content

AttributeError in parsing Python 3.10 parsing pattern matching with keyword arguments #634

Closed

Description

@tirkarthi

This doesn't happen with positional only argument matches but keyword argument pattern matching as below throws error.

import dataclasses


@dataclasses.dataclass()
class C(object):
    a: int
    b: int


c = C(1, 2)
match c:
    case C(a=a, b=b):
        found = True

Traceback

pyflakes /tmp/test_pattern_matching.py
Traceback (most recent call last):
  File "/root/checked_repos/attrs/.env/bin/pyflakes", line 8, in <module>
    sys.exit(main())
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/api.py", line 210, in main
    warnings = checkRecursive(args, reporter)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/api.py", line 155, in checkRecursive
    warnings += checkPath(sourcePath, reporter)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/api.py", line 99, in checkPath
    return check(codestr, filename, reporter)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/api.py", line 74, in check
    w = checker.Checker(tree, file_tokens=file_tokens, filename=filename)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 904, in __init__
    self.handleChildren(tree)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1359, in handleChildren
    self.handleNode(node, tree)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1406, in handleNode
    handler(node)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1166, in _unknown_handler
    self.handleChildren(node)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1359, in handleChildren
    self.handleNode(node, tree)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1406, in handleNode
    handler(node)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1166, in _unknown_handler
    self.handleChildren(node)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1359, in handleChildren
    self.handleNode(node, tree)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1406, in handleNode
    handler(node)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1166, in _unknown_handler
    self.handleChildren(node)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1359, in handleChildren
    self.handleNode(node, tree)
  File "/root/checked_repos/attrs/.env/lib/python3.10/site-packages/pyflakes/checker.py", line 1402, in handleNode
    node._pyflakes_depth = self.nodeDepth
AttributeError: 'str' object has no attribute '_pyflakes_depth'

Activity

  1. asottile commented on May 17, 2021

    @asottile
    Member

    match support is not at all implemented yet -- if you want to move that along please review #630

  2. tirkarthi commented on May 17, 2021

    @tirkarthi
    Author

    Sorry, search failed me. Please feel free to close it or as #630 is implemented. Thanks.

  3. asottile commented on Oct 5, 2021

    @asottile
    Member

    via #630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions