Skip to content

These changes allow for ML.NET to be built from source by VS2019 (#3… - #2

Merged
PranovD merged 1 commit into
PranovD:masterfrom
dotnet:master
May 17, 2019
Merged

PranovD merged 1 commit into
PranovD:masterfrom
dotnet:master

Conversation

@PranovD

@PranovD PranovD commented May 17, 2019

Copy link
Copy Markdown
Owner

…742)

  • These changes allow for ML.NET to be built from source by VS2019

  • Updates to files as per comments on pull request

  • Add support for x86 since VS 2019 project generator doesn't default to
    x86 anymore

We are excited to review your PR.

So we can do the best job, please check:

  • There's a descriptive title that will make sense to other developers some time from now.
  • There's associated issues. All PR's should have issue(s) associated - unless a trivial self-evident change such as fixing a typo. You can use the format Fixes #nnnn in your description to cause GitHub to automatically close the issue(s) when your PR is merged.
  • Your change description explains what the change does, why you chose your approach, and anything else that reviewers should know.
  • You have included any necessary tests in the same PR.

* These changes allow for ML.NET to be built from source by VS2019

* Updates to files as per comments on pull request

* Add support for x86 since VS 2019 project generator doesn't default to
x86 anymore
@PranovD
PranovD merged commit 61dee14 into PranovD:master May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant