Repository navigation
PSStyle: validate background index against BackgroundColorMap - #27106
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoMar 31, 2026
Conversation
FromAnsiColor checked backgroundColor against ForegroundColorMap.Length, which could throw or allow out-of-range values when the two maps differ in length. Use BackgroundColorMap.Length for the background bounds check.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a bounds-check bug in PSStyle.MapColorPairToEscapeSequence by validating the background color index against the background color map (instead of the foreground map), preventing incorrect ArgumentOutOfRangeException behavior if the map sizes ever diverge.
Changes:
- Update
MapColorPairToEscapeSequenceto comparebackIndextoBackgroundColorMap.Length.
Dongbo Wang (daxian-dbw)
approved these changes
Mar 31, 2026
Dongbo Wang (daxian-dbw)
left a comment
Dongbo Wang (daxian-dbw)
left a comment
Member
There was a problem hiding this comment.
LGTM. Thank you cui (@cuiweixie)!
Dongbo Wang (daxian-dbw)
added
the
CL-General
Dongbo Wang (daxian-dbw)
merged commit Mar 31, 2026
27c53ea
into
PowerShell:master
39 of 41 checks passed
Dongbo Wang (daxian-dbw)
pushed a commit
to daxian-dbw/PowerShell
that referenced
this pull request
Apr 13, 2026
3 of 9 tasks
Dongbo Wang (daxian-dbw)
added
Backport-7.6.x-Migrated
and removed
Backport-7.6.x-Approved
Backport-7.6.x-Migrated
labels
Justin Grote (JustinGrote)
pushed a commit
to JustinGrote/PowerShell
that referenced
this pull request
Jun 2, 2026
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
FromAnsiColorso the background color index is validated againstBackgroundColorMap.Lengthinstead ofForegroundColorMap.Length, matching the map used for conversion and avoiding incorrectArgumentOutOfRangeExceptionbehavior when the two maps differ in size.Changes
PSStyle.cs, comparebackIndextoBackgroundColorMap.Lengthin the background branch.Testing
ForegroundColorMapandBackgroundColorMaplengths can diverge in this codebase.