Repository navigation
Move _GetDependencies MSBuild target from dynamic generation in build.psm1 into Microsoft.PowerShell.SDK.csproj - #27052
Merged
Travis Plunk (TravisEz13) merged 4 commits intoMar 18, 2026
Conversation
…owerShell.SDK.csproj Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Travis Plunk (TravisEz13)
marked this pull request as ready for review
March 18, 2026 18:15
Travis Plunk (TravisEz13)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
March 18, 2026 18:15
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the _GetDependencies MSBuild target definition from a dynamically generated .targets file created by Start-TypeGen into the Microsoft.PowerShell.SDK.csproj, so builds-from-source don’t rely on writing transient targets into obj/.
Changes:
- Added
_GetDependenciestarget directly tosrc/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj. - Removed the transient
.targetsfile generation block fromStart-TypeGeninbuild.psm1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj |
Inlines _GetDependencies target so it’s available without generating/importing an obj/*.targets file. |
build.psm1 |
Removes the runtime creation of the .targets file while preserving the existing dotnet msbuild /t:_GetDependencies invocation flow. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…oss-platform path in comment Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies TypeGen by moving the _GetDependencies MSBuild target from a dynamically-generated .targets file in build.psm1 into the Microsoft.PowerShell.SDK.csproj, and standardizes native command execution in Start-TypeGen.
Changes:
- Added
_GetDependenciestarget directly tosrc/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj. - Removed dynamic generation of
obj/Microsoft.PowerShell.SDK.csproj.TypeCatalog.targetsfrombuild.psm1. - Wrapped
dotnet msbuildanddotnet runinStart-TypeGenwithStart-NativeExecution.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csproj | Defines _GetDependencies target in-project (instead of relying on an auto-imported generated targets file). |
| build.psm1 | Removes generated targets creation and uses Start-NativeExecution for TypeGen’s dotnet invocations. |
Aditya Patwardhan (adityapatwardhan)
approved these changes
Mar 18, 2026
Travis Plunk (TravisEz13)
deleted the
copilot/integrate-conditional-csproj
branch
March 18, 2026 21:28
Aditya Patwardhan (adityapatwardhan)
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 1, 2026
…ild.psm1` into `Microsoft.PowerShell.SDK.csproj` (PowerShell#27052) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
3 of 9 tasks
Aditya Patwardhan (adityapatwardhan)
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 2, 2026
…ild.psm1` into `Microsoft.PowerShell.SDK.csproj` (PowerShell#27052) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
3 of 9 tasks
Aditya Patwardhan (adityapatwardhan)
pushed a commit
to adityapatwardhan/PowerShell
that referenced
this pull request
Apr 2, 2026
…ild.psm1` into `Microsoft.PowerShell.SDK.csproj` (PowerShell#27052) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
3 of 9 tasks
Justin Grote (JustinGrote)
pushed a commit
to JustinGrote/PowerShell
that referenced
this pull request
Jun 2, 2026
…ild.psm1` into `Microsoft.PowerShell.SDK.csproj` (PowerShell#27052) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj-contribs/PowerShell
that referenced
this pull request
Aug 6, 2026
…ild.psm1` into `Microsoft.PowerShell.SDK.csproj` (PowerShell#27052) Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TravisEz13 <10873629+TravisEz13@users.noreply.github.com> Co-authored-by: Travis Plunk <travis.plunk@microsoft.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Start-TypeGeninbuild.psm1dynamically writes a.targetsfile containing the_GetDependenciesMSBuild target tosrc/Microsoft.PowerShell.SDK/obj/Microsoft.PowerShell.SDK.csproj.TypeCatalog.targets_GetDependenciestarget directly intosrc/Microsoft.PowerShell.SDK/Microsoft.PowerShell.SDK.csprojbuild.psm1dotnet msbuildanddotnet runcalls inStart-TypeGenwithStart-NativeExecutionfor consistent exit-code handling.\dummy.csproj→./dummy.csprojin the csproj comment for cross-platform correctness📍 Connect Copilot coding agent with Jira, Azure Boards or Linear to delegate work to Copilot in one click without leaving your project management tool.