Repository navigation

QR Decomposition Method Object Refactoring - #288

Merged

hemalvarambhia merged 33 commits into

qr-method-object-refactoring

Sep 5, 2022

Merged

QR Decomposition Method Object Refactoring#288
hemalvarambhia merged 33 commits into
masterfrom
qr-method-object-refactoring

Commits on Aug 28, 2022
Commits on Aug 30, 2022
- Inlined some local variables, made the decomposeWithPivot method look more similar to decompose.
  hemalvarambhia
  committed
  c3429d3
Commits on Aug 31, 2022
- Used a more sensible name, derived from the wikipedia entry.
  hemalvarambhia
  committed
  c7c78be
Commits on Sep 1, 2022
- Improved the name of the temporary variable.
  hemalvarambhia
  committed
  f8e215e
Commits on Sep 4, 2022
- Added a test that gets to the route of the problem.
  hemalvarambhia
  committed
  b177938
- Promoted the Q and R to state variables as they are duplicated in the decomposition methods.
  hemalvarambhia
  committed
  e6de63d
- Extracted a pivot temporary variable.
  hemalvarambhia
  committed
  21c9206
- Inproved the names of some temporary variables.
  hemalvarambhia
  committed
  bc694d5
- Improved the name of the temporary variables.
  hemalvarambhia
  committed
  c44c1f5
- Corrected the name of the temporary variable.
  hemalvarambhia
  committed
  252e4b3
- Use an already existing intention-revealing message.
  hemalvarambhia
  committed
  ddd5c9d
- Moved code to a more sensible place.
  hemalvarambhia
  committed
  1b363b1
- Inproved the names of some variables.
  hemalvarambhia
  committed
  1f3c181
- Improved the name of a variable.
  hemalvarambhia
  committed
  d65b739
Commits on Sep 5, 2022
- Improved the name of a temporary variable.
  hemalvarambhia
  committed
  c9a16de
- Extracted logic to a more sensible place, enhancing encapsulation.
  hemalvarambhia
  committed
  19fd4ac
- Made similar code even more similar.
  hemalvarambhia
  committed
  312ea6b
- Made similar code even more similar.
  hemalvarambhia
  committed
  e0ea3ab
- Made similar code even more similar.
  hemalvarambhia
  committed
  7742d67
- Made the name of the local variable the same.
  hemalvarambhia
  committed
  f6199b3