Skip to content
Navigation Menu
Sign in
Appearance settings
Platform
AI CODE CREATION
GitHub Copilot
Write better code with AI
GitHub Copilot app
Direct agents from issue to merge
MCP Registry
Integrate external tools
DEVELOPER WORKFLOWS
Actions
Automate any workflow
Codespaces
Instant dev environments
Issues
Plan and track work
Code Review
Manage code changes
Code Quality
Enforce quality at merge
APPLICATION SECURITY
GitHub Advanced Security
Find and fix vulnerabilities
Code security
Secure your code as you build
Secret protection
Stop leaks before they start
EXPLORE
Why GitHub
Documentation
Blog
Changelog
Marketplace
View all features
Solutions
BY COMPANY SIZE
Enterprises
Small and medium teams
Startups
Nonprofits
BY USE CASE
App Modernization
DevSecOps
DevOps
CI/CD
View all use cases
BY INDUSTRY
Healthcare
Financial services
Manufacturing
Government
View all industries
View all solutions
Resources
EXPLORE BY TOPIC
AI
Software Development
DevOps
Security
View all topics
EXPLORE BY TYPE
Customer stories
Events & webinars
Ebooks & reports
Business insights
GitHub Skills
SUPPORT & SERVICES
Documentation
Customer support
Community forum
Trust center
Partners
View all resources
Open Source
COMMUNITY
GitHub Sponsors
Fund open source developers
PROGRAMS
Security Lab
Maintainer Community
GitHub Stars
Archive Program
REPOSITORIES
Topics
Trending
Collections
Enterprise
ENTERPRISE SOLUTIONS
Enterprise platform
AI-powered developer platform
AVAILABLE ADD-ONS
GitHub Advanced Security
Enterprise-grade security features
Copilot for Business
Enterprise-grade AI features
Premium Support
Enterprise-grade 24/7 support
Pricing
Search
/
Sign in
Sign up
Appearance settings
You signed in with another tab or window.
Reload
to refresh your session.
You signed out in another tab or window.
Reload
to refresh your session.
You switched accounts on another tab or window.
Reload
to refresh your session.
Dismiss alert
{{ message }}
PolyMathOrg
PolyMath
Repository navigation
Code
Issues
58
(58)
Pull requests
Discussions
Actions
Projects
Wiki
Security and quality
Insights
More
items
[Issue 106] Refactor Math-Accuracy
- #139
#139
Merged
SergeStinckwich
merged 19 commits into
development
PolyMathOrg/PolyMath:development
from
issue-106-refactor-accuracy
PolyMathOrg/PolyMath:issue-106-refactor-accuracy
Copy head branch name to clipboard
Jul 17, 2019
Conversation
Commits
19
(19)
Checks
Files changed
Merged
[Issue 106] Refactor Math-Accuracy
#139
SergeStinckwich
merged 19 commits into
development
PolyMathOrg/PolyMath:development
from
issue-106-refactor-accuracy
PolyMathOrg/PolyMath:issue-106-refactor-accuracy
Copy head branch name to clipboard
Commits
Commits on Jul 7, 2019
[issue-106] Improved message names.
hemalvarambhia
committed
6c96651
View commit details
Copy full SHA for 6c96651
Browse repository at this point
[issue-106] The happy path should not be the guard clause; normally the subclass should respond to the message.
hemalvarambhia
committed
8cdadd5
View commit details
Copy full SHA for 8cdadd5
Browse repository at this point
[issue-106] Improved the name of the block variable.
hemalvarambhia
committed
79ce907
View commit details
Copy full SHA for 79ce907
Browse repository at this point
[issue-106] Moved related code closer together. initRest goes on to populate parameters, arguments and results.
hemalvarambhia
committed
81967ac
View commit details
Copy full SHA for 81967ac
Browse repository at this point
[issue-106] The asString message send is redundant.
hemalvarambhia
committed
d2596fc
View commit details
Copy full SHA for d2596fc
Browse repository at this point
[issue-106] Improved the name of the temp variable.
hemalvarambhia
committed
ce8ccbe
View commit details
Copy full SHA for ce8ccbe
Browse repository at this point
[issue-106] Improved the names of the block variables.
hemalvarambhia
committed
8b100f2
View commit details
Copy full SHA for 8b100f2
Browse repository at this point
[issue-106] The asString is redundant as the tests remain green.
hemalvarambhia
committed
0183720
View commit details
Copy full SHA for 0183720
Browse repository at this point
Commits on Jul 9, 2019
[issue-106] Extracted code to an intention-revealing method.
hemalvarambhia
committed
fdc4862
View commit details
Copy full SHA for fdc4862
Browse repository at this point
[issue-106] Simplified the calculation of the occurence of a key.
hemalvarambhia
committed
545dd06
View commit details
Copy full SHA for 545dd06
Browse repository at this point
[issue-106] Inlined the temporary variable as it is now redundant.
hemalvarambhia
committed
71b5377
View commit details
Copy full SHA for 71b5377
Browse repository at this point
Commits on Jul 12, 2019
[issue-106] Extracted an code to an intention-revealing local temp and improved ormatting.
hemalvarambhia
committed
91ef7e1
View commit details
Copy full SHA for 91ef7e1
Browse repository at this point
[issue-106] Inlined the variable as it over wrote the earlier assignment.
hemalvarambhia
committed
dc4a0d6
View commit details
Copy full SHA for dc4a0d6
Browse repository at this point
[issue-106] The initialize call looks like a special case, so transformed it into a guard clause.
hemalvarambhia
committed
234ed44
View commit details
Copy full SHA for 234ed44
Browse repository at this point
[issue-106] Improved code formatting.
hemalvarambhia
committed
1a2af4e
View commit details
Copy full SHA for 1a2af4e
Browse repository at this point
[issue-106] The check is redundant now because we have got passed the guard clause.
hemalvarambhia
committed
f40c4d8
View commit details
Copy full SHA for f40c4d8
Browse repository at this point
Commits on Jul 13, 2019
[issue-106] The nil check is unnecessary now given the ifNone: call. The call to join: is for efficiency (O(n) vs O(n^2) for concatenation). This was recommended by Pharo.
hemalvarambhia
committed
a71833c
View commit details
Copy full SHA for a71833c
Browse repository at this point
[issue-106] Reverted the change as we are only concatenating two strings which is not super inefficient.
hemalvarambhia
committed
d6b5105
View commit details
Copy full SHA for d6b5105
Browse repository at this point
Commits on Jul 16, 2019
[issue-106] Removed obselete code.
hemalvarambhia
committed
c497a3d
View commit details
Copy full SHA for c497a3d
Browse repository at this point
You can’t perform that action at this time.