add support for diagonal function? #91

Activity

1. SergeStinckwich

   added a commit that references this issue on Mar 29, 2019

   Support for principalDiagonal function #91 (#92)

   3e8d1ee
2. SergeStinckwich commented on Mar 30, 2019

   

   SergeStinckwich

   on Mar 30, 2019

   Member

   More actions

   I dunno how it happens, but there was a missing ] in your commit : 3e8d1ee#diff-ae5284ffc9b9802fb493ca318d25b044
   You edit the file by hand ?

   Your commit was push to dev branch. Thank you.
3. SergeStinckwich

   closed this as completedon Mar 30, 2019
4. SergeStinckwich

   added this to the 1.0 milestone on Mar 30, 2019
5. fuhrmanator commented on Mar 30, 2019

   

   fuhrmanator

   on Mar 30, 2019 via email

   Author

   More actions

   My edit by hand of what I thought was just a single file caused a huge change that I don't understand. Can you check this? The ] appears to have been lost in this merge. I think what happened was I hand edited a file on a different branch? I am very sorry and won't try that ever again! 3db369c

   …

   On Sat, Mar 30, 2019, 11:33 Serge Stinckwich ***@***.***> wrote: I dunno how it happens, but there was a missing ] in your commit : 3e8d1ee #diff-ae5284ffc9b9802fb493ca318d25b044 <3e8d1ee#diff-ae5284ffc9b9802fb493ca318d25b044> You edit the file by hand ? Your commit was push to dev branch. Thank you. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#91 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHQRDB2ehgar1mTCRm11-TGDRZPU0NdZks5vbz10gaJpZM4boDHH> .
6. SergeStinckwich commented on Mar 31, 2019

   

   SergeStinckwich

   on Mar 31, 2019

   Member

   More actions

   Ok there is no problem, Christopher :-) We should be more vigilant when we accept PR and avoid as much as possible to edit by hand. Next time I will spend more time looking at the CI.
7. SergeStinckwich

   added a commit that references this issue on Aug 21, 2019

   Merge dev commits to master for the 1.0 release (#145)

   ...

   6a3657a