Repository navigation
Some tests are failing randomly from time to time #279
Description
This is probably because they don't set the random state.
For example:
- PMQRTest >> testMPInverse
{{ message }}
This is probably because they don't set the random state.
For example:
Activity
hemalvarambhia commentedon Jun 20, 2022
I've begun looking into this. Could you clarify what should happen when random state is set, please? As an alternative, I wondered whether a simpler test could be written. The current one is difficult for me to follow.
hemalvarambhia commentedon Jun 26, 2022
I've begun carefully refactoring the testMoorePenroseInverse test to enhance clarity (Four Elements of Simple Design).
To effectively test the Moore Penrose Inverse computation, is it necessary to set random state, @olekscode ? Due to my complete ignorance I am unsure of why.
Thank you.
hemalvarambhia commentedon Jun 29, 2022
Another test that's failing is
hemalvarambhia commentedon Jun 29, 2022
Another test that's failing erratically:
hemalvarambhia commentedon Jun 29, 2022
testQRFactorisationinPMQRTestfails erraticallyhemalvarambhia commentedon Jul 3, 2022
@olekscode I think I managed to corner the input matrix that is responsible for the erratically failing test:
This fails for the same reason as highlighted during the CI run. Thus we have a deterministic test we can use to corner the failure much more.
If you'd like to investigate with me, you can find this in
investigate-erratic-testDoes the above matrix relate in some way to your hypothesis of not setting the random state.
My investigate points to an array
(3 4 3 nil)- the nil appears to be the cause.jecisc commentedon Nov 29, 2022
I confirm this random failure:
PMNumericalMethodsTestCase
✗ #testOptimizeOneDimension (12ms)
TestFailure: Assertion failed
PMNumericalMethodsTestCase(TestAsserter)>>assert:description:resumable:
PMNumericalMethodsTestCase(TestAsserter)>>assert:description:
PMNumericalMethodsTestCase(Object)>>assert:
PMNumericalMethodsTestCase>>testOptimizeOneDimension ...assert: (maximum - 5) abs < 1.0e-6
PMNumericalMethodsTestCase(TestCase)>>performTest
jecisc commentedon Mar 13, 2023
I fixed this one and all related to random matrix and vectors: PolyMathOrg/vector-matrix@5fb38e9