Repository navigation
PMVector > < operators modify in-place #122
Description
They should be returning a new PMVector.
Code to replicate:
x := #(1 2.5 3 4) asPMVector.
x > 2.
x. "==> a PMVector(false true true true)"
This affects PMMatrix due to it:
x := PMMatrix rows: #(#(1 2.5 3 4) #(1 2 3 8) #(23 2 5 7) #(23 2 7 6)).
y := PMMatrix rows: #(#(1 2.5 3 4) #(1 2 3 8) #(23 2 5 7) #(23 2 7 6)).
x > y. " Error "
primarily due to it using rowsCollect, which applies block directly to rows (PMVectors).
Using columnsCollect does not modify the Matrix in-place, as columnsCollect creates a copy of column and passes it to the PMVector > operator.
Activity
AtharvaKhare commentedon May 26, 2019
Also, should
>=and<=operators be added as-well?[PolyMathOrg#122] Fix PMVector comparison operators
[#122] Fix PMVector comparison operators (#123)
Merge dev commits to master for the 1.0 release (#145)