Skip to content

/metrics serves Help text "(ADR-0304 Phase 4 stub)" for a metric that is fully wired #425

Open

Description

@konih

Severity: Low (operator-visible text is wrong)

Evidence

  • internal/metrics/aggregation.go:26: Help: "Domain metric series from collected custom resources (ADR-0304 Phase 4 stub).", which is served on /metrics. The same string is at metrics_catalog.go:201 and metrics.go:149.
  • The metric is not a stub: RecordCustomResourceSeries is wired (collect/metrics_snapshot.go → aggregation_labeled.go).
  • internal/metrics/metrics_catalog.go:17 says "Keep in sync with … docs/PERFORMANCE.md", but that file does not exist. The real page is docs/operator-manual/performance.md.

Recommended fix

Drop "Phase 4 stub" from all three strings and fix the catalogue comment path.


Source: consolidated multi-model review (2026-10-04, verified at 34cfeaa4); re-verified against main @ e794bb67 (after #413).

Activity

  1. added
    bugSomething isn't working
    on Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions