Repository navigation
MAINT: Migrate to PyCalphad Workspace - #256
Merged
bocklund merged 23 commits intoAug 9, 2024
Merged
Conversation
… doesn't do anything
… for what should be a zero
Member
Author
|
Added some code to utilize a special This is pretty close to being able to be merged, but there's a significant performance regression for ZPF data (~20x slowdown) that I want to fix, or at least make a significant dent in. |
bocklund
marked this pull request as ready for review
August 8, 2024 20:29
bocklund
commented
Aug 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workspace. This allowed us to remove severalespei.shadow_functionsthat are no longer necessary.Workspace, ESPEI no longer needs to use a heuristic and hack the solver to prevent adding composition sets for constrained equilibria in ZPF data because this functionality is replaced byIsolatedPhase. This should resolve several bugs where the heurisitic for choosing points was too narrow (not allowing any points to be selected) or too broad (with bad starting points selected that could give metastable equilibria).PhaseRecordFactoryobjectsunpack_components->unpack_speciesImmutableDenseMatrixof symbolic coefficients in parameter selection now that PyCalphadSymbolobjects define a__getitem__method. See Subclassed Symbols that define__getitem__breakDenseMatrixsymengine/symengine.py#485 for more details.pointsmatricies inplot_endmemberandplot_interaction(_compare_data_to_parametersis getting removed as deprecated in a future PR)Some out of scope things for future work:
update_phase_records, as this is a non-trivial amount of time in benchmarking