Repository navigation
Drain covered LiDAR frames before reading more input - #189
Merged
Merged
Conversation
Member
|
Thanks for the fix. I'll just take the one line change in the package proper. no need for a test. |
Contributor
Author
|
Thanks! I've reduced the PR to the one-line change in the sequencer and kept the regression checks locally. |
Contributor
Author
|
Thanks for reviewing and merging the fix!
Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sequencer can drop buffered LiDAR frames at end of input even when the final IMU message already covers them. After emitting one covered frame it resumes reading the input iterator; if that iterator is exhausted, it exits before emitting the remaining ready frames.
This adds
continueafter a frame is emitted so the next iteration checks the buffer again before reading more input. The existing strict IMU coverage condition remains unchanged.Per the maintainer's feedback, the PR now contains only the one-line change in the package. The regression tests used for the original validation are retained locally rather than included in this patch.
Validation: the original 11 regression cases had three failures before the fix and all passed afterward; the complete 53-case Python suite and Ruff checks passed with the added local tests. That validation used the current Python source with the published RKO-LIO 0.4.0 Windows native extension; I have not rebuilt the full C++ extension or run a ROS node locally.