Repository navigation
Typo in Index buffer Section #288
Description
Hello, I've found some inconsistencies between the text and the source code in the index buffer section.
1.
Using an index buffer for drawing involves two changes to createCommandBuffers.
In the source code, we made changes to recordCommandBuffer instead of createCommandBuffers.
The text shows
vkCmdBindVertexBuffers(commandBuffers[i], 0, 1, vertexBuffers, offsets);
vkCmdBindIndexBuffer(commandBuffers[i], indexBuffer, 0, VK_INDEX_TYPE_UINT16);
vkCmdDrawIndexed(commandBuffers[i], static_cast<uint32_t>(indices.size()), 1, 0, 0, 0);
, but the source code shows:
vkCmdBindVertexBuffers(commandBuffer, 0, 1, vertexBuffers, offsets);
vkCmdBindIndexBuffer(commandBuffer, indexBuffer, 0, VK_INDEX_TYPE_UINT16);
vkCmdDrawIndexed(commandBuffer, static_cast<uint32_t>(indices.size()), 1, 0, 0, 0);
Thanks,
Zixin
Activity
Overv commentedon May 16, 2022
Thanks for reporting. I've fixed this and a bunch of other inconsistencies.
Fix parts of the tutorial that weren't update to match the code (fixes …