Skip to content

[TeamComments extension] Delete comments associated with a page along with the page? #10

Open

Description

@kfogel

In the TeamComments extension, we should consider hooking into the MediaWiki page deletion API so that the comments associated with a given page are deleted when that page is deleted.

Filing a ticket so we don't forget to think about this (see the "Action items" section in the 2019-10-24 meeting notes.

Activity

  1. changed the title [-][TeamComments extension] Hook into MediaWiki page deletion API so associated comments are deleted when page is?[/-] [+][TeamComments extension] Delete comments associated with a page along with the page?[/+] on Oct 26, 2019
  2. frankduncan commented on Jan 2, 2020

    @frankduncan
    Collaborator

    One thing that makes this need more discussion is that mediawiki supports restoring pages, which then returns the page to the previous ID. When that happens, the current TeamComments functionality restores the comment chain as it was.

    So the choice in front of us is:

    • Keep current functionality. The risk is bloated DB (not a big risk), and comment aggregation pages need to be aware that comments may be linked to pages that are dead
    • Delete comments when pages is deleted, and just lose them if page is restored.
    • Mirror what mediawiki does, and hook into both delete and restore actions, and have a secondary table where "deleted comments" live.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions