Skip to content

Cleanup: small code issues #35

Closed

Description

@compot-dev

Small items found during review, none of them user-visible on their own:

  • proguard-rules.pro keeps com.openipc.decoder.Decoder$Frame, which no longer exists (Frame is now a top-level class).
  • RtspClient.start() creates Executors.newFixedThreadPool(5) but only submits 2 tasks.
  • FramePool mixes small RTP buffers and NAL buffers of up to 1 MiB. A large request discards whatever small frame it polls, and small requests take the large buffers, so key frames always allocate and the pool can hold about 50 MiB.
  • takeScreenshot() compresses a full-resolution PNG on the UI thread, which causes a visible stutter.
  • RtspClient (line ~303): indentation is misleading (SuspiciousIndentation lint error).
  • MediaCodecManager hard-codes 1280×720 and KEY_MAX_INPUT_SIZE = 1 MiB in the input format. 4K streams with large I-frames may need more.

Activity

  1. added a commit that references this issue on Oct 12, 2026
    8c26ffb
  2. added a commit that references this issue on Oct 12, 2026
  3. added 2 commits that reference this issue on Oct 15, 2026
    20b37bb
    d86b938
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions