Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transfer forms: existing owners, no selector dispatch
Uninstalled dependent draft. Its temporary ancestry is the Forms owner's WIP checkpoint cc91178; that ancestry is not a build recipe or a promotion-ready foundation. The consumer's supported interface target is ea33717 with its matching pins: Textual e2fd8a336, ObjectState82a62132, FormBridge1a45b8e0. Codex owns current-main integration of that foundation and the complete reviewed graph before publication. Do not bring cc91178's unfinished ParameterInfo migration merely by merging this branch.
Consumer source head
a4751c0f2; functional fixfa6c82c78. Final consumer diff changes onlysrc/toad/widgets/comms_transfer.py. The agent-authored CLAUDE.md line was reverted separately; no project-instruction diff remains.Ownership and deletion
TransferDialogfinishes edits and constructs the original typed request..text, not the previous hard-coded.txt; custom destinations are retained.Before/after evidence
Against this PR's parent cc91178, one complete consumer family:
Before: IDs and handler selectors in both dialog constructors, mount/focus, field collection and validation. After:
TransferDialog.__init__retained references, native form field bindings, and the two Fields.request implementations. No field-value collection through the DOM remains. Do not credit this PR with its parent's unrelated Forms deletions or combine its global count with the main-based #682 count.Reused audit.Package parsing: Toad 282 modules, native Textual254, Forms Toad284, FormBridge92, ObjectState30; zero parse omissions. Relevant declarations, imports, inheritance, writes, lookups, conversion and lifecycle consumers were read. Dynamic family discovery is not whole-program behavioral proof.
Real application results, not installed acceptance
Plain st on isolated :278, existing saved toad-ui-2 session, no provider input or export/import operation:
/home/ts/.cache/agent-scratch/toad-ui-2-transfer-native-layout/.BreathingSweep.scaledAPI failure. This was sent to the theme owner as 36fd060bdce8; it is not a save-path error and did not block the dialog checks.export-narrow.pngandimport-narrow.pngplus receipts:/home/ts/.cache/agent-scratch/toad-ui-2-transfer-installed-760d/. This installed package still contains the old CSS/query dialogs, not this PR. Its foreground, ACP/pools and owned display were also closed after checking.Precise integration gap
Not merged, installed or accepted against current Core. The demonstrated source cohort is not the Forms parent's pinned build: cc91178 pins FormBridge 1a45b8e0, while the dialog run used dc5d21e4. That revision changes field selection and deletes two service implementations. The passing checks do not validate 1a45b8e0 or an interchangeable build. The actual source-overlay heads are listed above; its immutable launcher/dependency baseline is the af76d3b/Core21136feca runtime recorded by the run, with reviewed Core0800ff1c overlaid. No new build was produced.
A standalone UI-only import against installed Core46ee4a206 failed in the old parent at
toad/acp/status.py:4importing removed NativeTool. Codex's later trial merge of current main removes that import cleanly; no compatibility repair is needed. His Textual trial also preserves the current hint implementation. The remaining promotion blocker is the unfinished optional Forms work and a reviewed, complete dependency graph—not that stale import. Current Core already provides record_fields.The foundation owner additionally confirmed cc91178 has an internally mismatched manifest: ValueView.shows expects ParameterInfo to be a class, while pinned FormBridge1a45b8e0 defines ParameterInfo as a union. Source comparison ea33717→cc91178e3 shows only that internal import/selection substitution across the consumed form_view/field_path/presentation/declared_views files; the consumer-facing FormView constructor/finish, InlineFormView, FieldPath.bind and FormPart/FormModal contracts are unchanged. #683 uses those ea33717 interfaces and requires no WIP ParameterInfo API. No foundation implementation was copied or patched. The ea33717+1a45b8e0 target has not received the older dc5d21e4 run's acceptance by implication.
Core-route-counts retains foundation/nullable Forms ownership; Codex retains current-main integration and paired publication; UI2 retains this consumer and dialog verification. #683 remains uninstalled and is not promotion-ready.
No compatibility alias, Core overlay against the new runtime, installation, goal reset or UNKNOWN replay attempted. Raw startup/choice failures retained. Source imports (original cohort), syntax/count inspection and whitespace checks were used; no automated tests/fixtures and no performance claim.