Repository navigation
fix: sample interpolated wind at BEMT times - #3480
Draft
RanaPriyansh wants to merge 2 commits into
Draft
RanaPriyansh wants to merge 2 commits into
RanaPriyansh wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During
AD_UpdateStates, AeroDyn passed stale wind to both BEMT input slots and overwrote an original inflow sample. This changes forcing when wind and blade position vary with time.Sample wind at each
BEMT_utimes(i)intoInflowInterp. Keep the original input inflow arrays intact.Four new regression tests cover time varying wind, original inflow preservation, steady wind, and supplied inflow without a FlowField. The tests use moving geometry. Both defect assertions fail on the original source, while both controls pass. All four pass with this change. The existing
aerodyn_utestselector passes all five tests. The Fortran tab check passes.The 83 AeroDyn labeled CTest cases ran with unchanged tolerances after local controller and Python prerequisites were installed. The candidate passed 41 cases and failed 42 reference comparisons. All 42 failed cases completed simulation and produced paired outputs. Exact dev passed 40 of those cases and failed two existing references. The two existing failures have different failed channels or matrix cells on the candidate. No reference files changed. These numerical differences need maintainer review before the change is ready.
The full 207 case repository suite and all AA/FVW input pairings have not been validated.
Addresses #3447.
Codex used.