Repository navigation
fix: Return errors from NewDependencies instead of panicking - #756
Merged
Merged
Conversation
Commands now return an error and exit with code 1 when client setup fails, for example on HTTP 429 or an unknown space. Fixes #739 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
YuKitsune
marked this pull request as ready for review
October 15, 2026 04:09
sathvikkumar-octo
approved these changes
Oct 15, 2026
APErebus
pushed a commit
that referenced
this pull request
Oct 15, 2026
🤖 I have created a release *beep* *boop* --- ## [2.29.0](v2.28.0...v2.29.0) (2026-10-15) ### Features * Add release promote command ([#749](#749)) ([c3c2e27](c3c2e27)) ### Bug Fixes * Return errors from NewDependencies instead of panicking ([#756](#756)) ([82f7bc9](82f7bc9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: team-integrations-fnm-bot <integrationsfnmbot@octopus.com>
justin-newman
added a commit
to justin-newman/octopus-cli
that referenced
this pull request
Oct 21, 2026
NewDependencies returns an error since OctopusDeploy#756 instead of panicking. Return it from the view, delete and list commands as the other commands do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commands now return an error and exit with code 1 when client setup fails, for example on HTTP 429 or an unknown space.
Improved rate limiting handling will be addressed separately.
Fixes #739
Before
After