Repository navigation
feat: add wait-for-database startup script and HOST environment variable support - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds startup ergonomics for local/dev/CI by introducing a start.sh script that waits for Fuseki readiness, starts the Node server, and runs the EU-Rent population script, while also expanding environment-variable configurability for host and Jena endpoint.
Changes:
- Make the EU-Rent population script configurable via
BMM_SERVER_URL. - Add
start.shto wait for Fuseki, start the server, and run database population. - Add
HOSTandJENA_URLenvironment variable support in runtime configuration, and update the startup log banner.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
testing/populate-eurent.sh |
Allows overriding the server base URL via BMM_SERVER_URL. |
start.sh |
New startup script that waits for Fuseki/server readiness and runs EU-Rent population. |
src/env.ts |
Adds HOST bind support and allows overriding jenaURL via JENA_URL. |
src/app.ts |
Updates startup logging output/banner. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| # Run the population script | ||
| echo "Server is up! Running database population..." | ||
| ./testing/populate-eurent.sh |
Comment on lines
+60
to
+62
| console.log('\n============================================================'); | ||
| console.log('Browse the OSLC BMM Server at: http://localhost:' + env.listenPort + '/'); | ||
| console.log('============================================================\n'); |
| appBase, | ||
| ldpBase, | ||
| jenaURL: config.jenaURL, | ||
| jenaURL: process.env.JENA_URL || config.jenaURL, |
berezovskyi
force-pushed
the
feature/docker-compose-automation
branch
from
June 6, 2026 18:32
2365025 to
4a8210a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.