Repository navigation
Fix: os2forms_forloeb: Maestro notification attempts sending digital post that will never be delivered #195
Description
Problem
Digital post, SF1601, requires that recipientID is digits and is either 8 or 10 of them, depending on whether it is a CVR- or CPR-number. As of right now, this is described on page 19 of "SF1601 Postkomponent - KombiPostAfsend - Feltbeskrivelse" found in their compressed documentation package.
Consequently, dashes are not allowed in CPR-numbers.
Handling in digital post handler
This is unintentionally handled during the processing of jobs from the normal Digital Post handler by removing all non-digits which had the intention of helping detecting whether we were dealing with CVR or CPR.
Missing handling in Maestro notification handler
It is not (intentionally or unintentionally) handled during the processing of Maestro notifications jobs. This means that instances where maestro notifications have been sent to 'dashed' CPR-numbers will have never been received despite the submission log claiming it as being sent.
Interestingly, according to Kombit, these would have been sent as 'Fjern print' instead.
Note
As long as we do not use Beskedfordeleren, we have no way of knowing whether digital post has been delivered or not. We can however limit the scenarios in which we know digital post will never be received by removing non-digits as in the Digital Post handler case.
Activity
OS2Forms#195: Sanitize recipient identifier in Maestro notification
OS2Forms#195: Updated CHANGELOG
jekuaitk commentedon Sep 5, 2025
Hi @ds-bellcom
This is one of the issues we would like a review on!
[-]os2forms_forloeb: Maestro notification attempts sending digital post that will never be delivered[/-][+]Fix: os2forms_forloeb: Maestro notification attempts sending digital post that will never be delivered[/+]ds-bellcom commentedon Sep 11, 2025
Estimate: 1h (the review is done)!
ds-bellcom commentedon Oct 2, 2025
@jekuaitk Review is done (3 weeks ago). Will you merge it and close this issue when done?
CC: @Anna-itk @ChatBotBerg
Merge pull request #202 from itk-dev/hotfix/195-maestro-notication-re…
ds-bellcom commentedon Nov 12, 2025
@Anna-itk @lilosti @gBarlach Har I mulighed for at oprettet en formular med tilhørende flow på test.os2forms.dk, så ovenstående kan testes? Jeg ved desværre ikke hvordan I sætter dette op i Århus, så jeg har svært ved at guide Koordinationsgruppen til at teste dette!
CC: @ChatBotBerg
ds-bellcom commentedon Nov 14, 2025
@jekuaitk Troels har lavet en formular til test.
ds-bellcom commentedon Nov 17, 2025
@jekuaitk Skal denne stadig være åben eller kan den lukkes?
jekuaitk commentedon Nov 17, 2025
Jeg formoder Troels har fået det til at spille ift. test, så jeg lukker igen :-)