Repository navigation
Fix: Name- and address protection multiple submission saves issue #186
Description
We have encountered submissions that have sent (or attempted sending) multiple e-mails although users have not edited the submission.
After debugging it turned out that this is caused by the current logic revolving name- and address protection resulting in submissions being saved twice.
- Once when the webform is submitted
- Once when adding data to indicate address protection
This double saving results in e-mail handlers being ran twice, such that two e-mails get (attempted) sent.
Furthermore, if this is combined with renamed or sanitized files attached to e-mails, one of the e-mails may refer to non-existing filenames, causing confusion when webform owners view error logs.
Activity
#186: Avoid multiple saves when handling name and address protection
#186: Update CHANGELOG and apply coding standards
ds-bellcom commentedon Sep 1, 2025
We have estimated this review to be 2,25 hours. Let me know if it needs to be scheduled at Stan - @ChatBotBerg @gBarlach
[-]Name- and address protection multiple submission saves issue[/-][+]Fix: Name- and address protection multiple submission saves issue[/+]ds-bellcom commentedon Oct 13, 2025
@jekuaitk Review is done. Will you merge it and close this issue when done?
CC: @Anna-itk @ChatBotBerg
Merge pull request #187 from OS2Forms/feature/avoid-double-save-on-na…