Repository navigation
[18.0][MIG] vault: Migration to 18.0 - #875
Merged
Merged
Conversation
CarlosRoca13
force-pushed
the
18.0-MIG-vault
branch
2 times, most recently
from
December 11, 2025 18:07
ddb3f63 to
05c6e9a
Compare
Fix website in manifest Run pre-commit Move models to own files. Apply OCA conventions Remove logging causing the tests to fail Add application icon Split models into files. Use lambda for defaults Add icon to menuitem Use lambda as suggested Add missing keepass lib Show information if user lacks public key Add note about no https Fix domain for user_id in send wizard. Add permanent note to wizard
vault_controller
…lect all possible users due to access rights - Disable the features if browser isn't using a secure context (https/localhost) - Load required assets in inbox and share frontends - Allow the user to switch a parent of an entry within the same vault - Allow to create entries for vaults using the main menu Entries - Fix bug that encrypted a share twice due to multiple extension with VaultAbstract - Fix a bug on share create that throws a warning about changed values
…changed Note about disaster recovery project Add missing dependency to base_setup for res.config.settings view
Before the path if we create a new child entry from other entry, the complte_name of the entry is not changing when we save the new entry. Doing this changes, we are getting the complete_name correctly. TT38729
vault: Searchpanel improvements: - Add a domain to only show records with children. - Set limit to False. TT38731 vault: Add Vaults to searchpanel view. TT38731
…he fields and files aren't overwritten
… Re-encrypt vaults if the user changes the private key - Recompute access. Unittests
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-14.0/server-auth-14.0-vault Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-vault/
CarlosRoca13
force-pushed
the
18.0-MIG-vault
branch
2 times, most recently
from
December 12, 2025 16:38
b3237c1 to
3bd21c1
Compare
…d. Improve readme documentation about this requirement
Currently translated at 99.5% (202 of 203 strings) Translation: server-auth-16.0/server-auth-16.0-vault Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-vault/it/
Currently translated at 100.0% (203 of 203 strings) Translation: server-auth-16.0/server-auth-16.0-vault Translate-URL: https://translation.odoo-community.org/projects/server-auth-16-0/server-auth-16-0-vault/es/
When a field has assigned a value and we try to change it by using the secrets generator, the new value is not saved. It is happening because the click event on wizard buttons is propagated and this trigger the bus event RELATIONAL_MODEL:NEED_LOCAL_CHANGES. By doing this changes the value generated is assigned to the field without loosing the focus. So the value is saved. Steps to reproduce the problem: 1. Create a Vault 2. Create an Entry for the Vault 3. Create a Field for the Entry 4. Assign a value 5. Edit the value using the button to generate secrets 6. Save the new secret You will see that the value salected on wizard is not saved. TT49554
Before this changes, when the password was required some other click events can be thrown. To reproduce this problem: 1. Create a vault with an entry and a field 2. Clean session coockies 3. Without entering the private key, go to try change the field value 4. Set the private key and press enter The system will ask for the private key once again.
Up until now, when a field was decrypted, making a change would cause it to be lost, which could confuse the user. After fixing this, it happened that discarding the changes made it seem like the change had not been discarded. The measure that has been taken is to, upon discarding, do as saving does: hide the value of the field, and the change remains in the input as long as it is not saved, discarded, or hidden.
CarlosRoca13
force-pushed
the
18.0-MIG-vault
branch
4 times, most recently
from
December 15, 2025 17:58
ce3d6da to
10c2686
Compare
victoralmau
approved these changes
Dec 16, 2025
victoralmau
left a comment
victoralmau
left a comment
Member
There was a problem hiding this comment.
Code and functional review OK.
Some minor comments.
CarlosRoca13
force-pushed
the
18.0-MIG-vault
branch
from
December 16, 2025 14:13
10c2686 to
cc284ee
Compare
Author
|
Changes done @victoralmau |
victoralmau
approved these changes
Dec 16, 2025
1 task done
pedrobaeza
approved these changes
Dec 16, 2025
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
/ocabot migration vault
/ocabot merge nobump
18 of 23 tasks
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at a61defa. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT57934
ping @victoralmau @pedrobaeza