Skip to content

[MIG][16.0] Migration of vault_share - #612

Merged
OCA-git-bot merged 21 commits into
OCA:16.0from
initOS:16.0-mig-vault_share
Feb 29, 2024
Merged

[MIG][16.0] Migration of vault_share#612
OCA-git-bot merged 21 commits into
OCA:16.0from
initOS:16.0-mig-vault_share

Conversation

@fkantelberg

@fkantelberg fkantelberg commented Feb 2, 2024

Copy link
Copy Markdown
Member

Based on #611

The migration needed quite a rework because of the JS framework changes. (I hope the next are easier) I tested every functionality during migration but plan to do another round again soon.

There are some minor fixes which were possible to do:

  • Creating shares is now possible using the views
  • Better file handling. Inside of an entry you can share now

@fkantelberg fkantelberg mentioned this pull request Feb 2, 2024
Merged
@pedrobaeza

pedrobaeza commented Feb 2, 2024

Copy link
Copy Markdown
Member

/ocabot migration vault_share

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Feb 2, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 2, 2024
Open
19 of 22 tasks
@CarlosRoca13

CarlosRoca13 commented Feb 22, 2024

Copy link
Copy Markdown

Please rebase to get changes :)

CarlosRoca13
CarlosRoca13 approved these changes Feb 28, 2024
View reviewed changes

@CarlosRoca13 CarlosRoca13 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me 👍

@pedrobaeza

pedrobaeza commented Feb 28, 2024

Copy link
Copy Markdown
Member

@fkantelberg this one doesn't contain commit history. Please preserve it for also analyzing the specific changes done for 16.0

fkantelberg and others added 19 commits February 29, 2024 08:04
@fkantelberg
Add vault and vault_share module
76c1ff1 
Fix website in manifest

Run pre-commit

Move models to own files. Apply OCA conventions

Add application icon
@oca-travis @fkantelberg
Update vault_share.pot
0ac2f50
@OCA-git-bot @fkantelberg
README.rst
6fcc7c5
@fkantelberg
General fixes and improvements of the vault - Send wizard couldn't se…
67d75e2 
…lect all possible users due to access rights - Disable the features if browser isn't using a secure context (https/localhost) - Load required assets in inbox and share frontends - Allow the user to switch a parent of an entry within the same vault - Allow to create entries for vaults using the main menu Entries - Fix bug that encrypted a share twice due to multiple extension with VaultAbstract - Fix a bug on share create that throws a warning about changed values
@oca-travis @fkantelberg
Update vault_share.pot
c1435ab
CarlosRoca13 @fkantelberg
vault: Show just name instad of full path in searchpanel
5b5323a
oca-ci @fkantelberg
Update vault_share.pot
3c18165
@OCA-git-bot @fkantelberg
vault_share 14.0.1.2.0
7510934
@fkantelberg
Module vault and vault_share
5c5b2b6
Carlos Roca @fkantelberg
vault_share: File is not downloaded when clicking sharing link
395cda5
oca-ci @fkantelberg
Update vault_share.pot
f74c214
@OCA-git-bot @fkantelberg
README.rst
6ab6e02
@weblate @fkantelberg
Update translation files
ba9da7e 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: server-auth-15.0/server-auth-15.0-vault_share
Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-vault_share/
Bosd @fkantelberg
Added translation using Weblate (Dutch)
11b9bcb
Bosd @fkantelberg
Translated using Weblate (Dutch)
7fdfa68 
Currently translated at 17.0% (8 of 47 strings)

Translation: server-auth-15.0/server-auth-15.0-vault_share
Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-vault_share/nl/
Bosd @fkantelberg
Translated using Weblate (Dutch)
701bef7 
Currently translated at 74.4% (35 of 47 strings)

Translation: server-auth-15.0/server-auth-15.0-vault_share
Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-vault_share/nl/
@victoralmau @fkantelberg
Translated using Weblate (Spanish)
20fdcbe 
Currently translated at 87.2% (41 of 47 strings)

Translation: server-auth-15.0/server-auth-15.0-vault_share
Translate-URL: https://translation.odoo-community.org/projects/server-auth-15-0/server-auth-15-0-vault_share/es/
Carlos Roca @fkantelberg
vault, vault_share: Error on test
8fdda00 
With the changes introduced on odoo/odoo@a251b14#diff-99de14b6e0a411718ac3adaaf779395155841c7ca9d95fa258369656dae63d18
the tests of vault and vault_share are failing.
@OCA-git-bot @fkantelberg
vault_share 15.0.1.1.1
a24829b
@fkantelberg

fkantelberg commented Feb 29, 2024

Copy link
Copy Markdown
Member Author

Yes I haven't used format-patch again and the commits were shared between the vault and vault_share PR. Was weird and I re-did the entire process.

pedrobaeza
pedrobaeza reviewed Feb 29, 2024
View reviewed changes
Comment thread vault_share/__manifest__.py Resolved
Comment thread vault_share/migrations/16.0.1.1.1/post-migrate.py Resolved
Comment thread vault_share/models/res_config_settings.py Resolved
Comment thread vault_share/readme/DESCRIPTION.rst Resolved
Comment thread vault_share/static/description/icon.png

@pedrobaeza pedrobaeza Feb 29, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New standard size is 140x140. Don't you have the SVG?

@fkantelberg fkantelberg Feb 29, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was never a svg and I'm not good enough with these tools. I just used https://spilymp.github.io/ibo/ again with the new size.

@pedrobaeza

pedrobaeza commented Feb 29, 2024

Copy link
Copy Markdown
Member

Let's not be more picky asking to squash this last commit, but there's no advantage in GitHub putting separate commits for new additions in a PR, and the commit history is a bit worse having them split.

/ocabot merge nobump

@OCA-git-bot

OCA-git-bot commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-612-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 1cc4349 into OCA:16.0 Feb 29, 2024
@OCA-git-bot

OCA-git-bot commented Feb 29, 2024

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 41bab0e. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza left review comments
+1 more reviewer
@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

merged 🎉

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

7 participants

@fkantelberg @pedrobaeza @CarlosRoca13 @OCA-git-bot @oca-travis @weblate @victoralmau