[15.0][MIG] vault and vault_share by fkantelberg · Pull Request #389 · OCA/server-auth

fkantelberg · 2022-06-19T16:01:17Z

This is the migration of both vault modules to version 15.0 with migrating most of the JS to the newer esm.

oca-clabot · 2022-09-21T06:49:51Z

Hey @fkantelberg, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

oca-ci oca-ci@odoo-community.org (no github login found)

Appreciation of efforts,
OCA CLAbot

CRogos · 2022-10-06T09:02:31Z

To fix build, please rebase.

CRogos · 2022-10-25T07:22:41Z

Did you follow the migration tasks?
https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-15.0

I think some commits need to be squashed, the version needs to be corrected, ... I know, I went throw this hell myself, but in the end we all profit from it.

fkantelberg · 2022-10-25T07:32:37Z

@CRogos Thank you for the reminder. I did it at the start but afterwards some fixes came up for the other branches and the history got messy because of it. There are currently 2 active PR for problems in 13.0 and 14.0 afterwards I can clean up the history here again.

fkantelberg · 2022-12-05T07:06:23Z

@CRogos I rebased everything and the commit history should be fine. Functional tests are also all green.

CRogos · 2022-12-05T07:52:49Z

Looks better now. I think It is not an big issue but for the future, there should be two commits:
[IMP] $MODULE: black, isort, prettier
[MIG] $MODULE: Migration to 15.0

The pre-commit issue should be fixed by PR: #453
maybe you can rebase as soon as it is available in the 15.0 branch.

pedrobaeza · 2022-12-05T07:56:26Z

Pre-commit fix merged.

…he fields and files aren't overwritten

…lost - Re-encrypt vaults if the user changes the private key - Recompute access. Unittests

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-14.0/server-auth-14.0-vault Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-vault/

CarlosRoca13

All working well 👍

But please add this change when PR is merged 😄 #499

pedrobaeza · 2023-03-20T18:18:39Z

@fkantelberg can you add the missing PR for merging this?

pedrobaeza · 2023-03-21T07:19:09Z

/ocabot migration vault

pedrobaeza · 2023-03-21T07:19:23Z

/ocabot migration vault_share
/ocabot merge nobump

OCA-git-bot · 2023-03-21T09:13:54Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-389-by-pedrobaeza-bump-nobump, awaiting test results.

Signed-off-by pedrobaeza

OCA-git-bot · 2023-03-21T09:18:51Z

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-389-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

pedrobaeza · 2023-03-23T18:00:03Z

/ocabot merge nobump

OCA-git-bot · 2023-03-23T18:00:19Z

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-389-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-03-23T18:06:50Z

Congratulations, your PR was merged at ac93e94. Thanks a lot for contributing to OCA. ❤️

Syncing from upstream OCA/server-auth (16.0)

fkantelberg force-pushed the 15.0-mig-vault branch 2 times, most recently from 4de4d4a to dca3d30 Compare June 19, 2022 16:26

fkantelberg changed the title ~~[15.0][MIG] vault and vault_share~~ [15.0][MIG][WIP] vault and vault_share Sep 4, 2022

fkantelberg force-pushed the 15.0-mig-vault branch from c710879 to 75ee5ab Compare September 22, 2022 07:03

fkantelberg force-pushed the 15.0-mig-vault branch 2 times, most recently from a84b2cf to d4222ba Compare October 14, 2022 06:52

fkantelberg force-pushed the 15.0-mig-vault branch 2 times, most recently from 0a4f572 to 844789f Compare November 29, 2022 17:40

fkantelberg changed the title ~~[15.0][MIG][WIP] vault and vault_share~~ [15.0][MIG] vault and vault_share Nov 30, 2022

fkantelberg force-pushed the 15.0-mig-vault branch from 844789f to ef98102 Compare December 3, 2022 12:29

fkantelberg added 13 commits December 5, 2022 08:57

Add vault and vault_share module

fa82028

Fix website in manifest

1948bc7

Run pre-commit

fab81ac

Move models to own files. Apply OCA conventions

102e7e5

Remove logging causing the tests to fail

000d45d

Add application icon

be73067

Split models into files. Use lambda for defaults

1b5559f

Add icon to menuitem

944befa

Use lambda as suggested

c5431ca

Add missing keepass lib

4b277f1

Show information if user lacks public key

e631755

Add note about no https

1a2a1e7

Fix domain for user_id in send wizard. Add permanent note to wizard

e817b5a

fkantelberg and others added 7 commits December 5, 2022 08:57

Fix locking secrets because on re-encryption after removal of users t…

9ef35d4

…he fields and files aren't overwritten

vault 14.0.1.7.1

fd31767

[IMP] Allow an user to invalidate the current key if the password is …

03b03df

…lost - Re-encrypt vaults if the user changes the private key - Recompute access. Unittests

[UPD] Update vault.pot

9619ea9

vault 14.0.1.8.0

c7000d0

Update translation files

ef2920f

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-auth-14.0/server-auth-14.0-vault Translate-URL: https://translation.odoo-community.org/projects/server-auth-14-0/server-auth-14-0-vault/

[MIG][15.0] Module vault and vault_share

77f4537

fkantelberg force-pushed the 15.0-mig-vault branch from ef98102 to 77f4537 Compare December 5, 2022 07:57

[FIX] vault_share: File is not downloaded when clicking sharing link

01d3c2d

pedrobaeza requested a review from CarlosRoca13 January 18, 2023 08:06

CarlosRoca13 approved these changes Mar 20, 2023

View reviewed changes

[IMP] vault: vault readonly when it's defined

f1c50c1

OCA-git-bot added this to the 15.0 milestone Mar 21, 2023

OCA-git-bot mentioned this pull request Mar 21, 2023

Migration to version 15.0 #299

Closed

10 of 18 tasks

OCA-git-bot added the bot is merging ⏳ label Mar 21, 2023

OCA-git-bot added a commit that referenced this pull request Mar 21, 2023

Merge PR #389 into 15.0

b77cfd2

Signed-off-by pedrobaeza

OCA-git-bot removed the bot is merging ⏳ label Mar 21, 2023

OCA-git-bot added the bot is merging ⏳ label Mar 23, 2023

OCA-git-bot merged commit 6e39ee2 into OCA:15.0 Mar 23, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Mar 23, 2023

SiesslPhillip pushed a commit to grueneerde/OCA-server-auth that referenced this pull request Nov 20, 2024

Merge pull request OCA#389 from OCA/16.0

1ad8b77

Syncing from upstream OCA/server-auth (16.0)

Conversation

fkantelberg commented Jun 19, 2022

Uh oh!

oca-clabot commented Sep 21, 2022

Uh oh!

CRogos commented Oct 6, 2022

Uh oh!

CRogos commented Oct 25, 2022

Uh oh!

fkantelberg commented Oct 25, 2022

Uh oh!

fkantelberg commented Dec 5, 2022

Uh oh!

CRogos commented Dec 5, 2022

Uh oh!

pedrobaeza commented Dec 5, 2022

Uh oh!

CarlosRoca13 left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Mar 20, 2023

Uh oh!

pedrobaeza commented Mar 21, 2023

Uh oh!

pedrobaeza commented Mar 21, 2023

Uh oh!

OCA-git-bot commented Mar 21, 2023

Uh oh!

OCA-git-bot commented Mar 21, 2023

Uh oh!

pedrobaeza commented Mar 23, 2023

Uh oh!

OCA-git-bot commented Mar 23, 2023

Uh oh!

OCA-git-bot commented Mar 23, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants