Skip to content

[10.0] [ADD] ability to set jobs to done in batch - #59

Merged
yvaucher merged 1 commit into
OCA:10.0from
CompassionCH:10.0
Jun 20, 2018
Merged

yvaucher merged 1 commit into
OCA:10.0from
CompassionCH:10.0

Conversation

@ecino

@ecino ecino commented Feb 22, 2018

Copy link
Copy Markdown

In our production database, we have a lot of failed jobs that we only need to put as done, because there is no real other action to do. For us, it's boring to go through all the form views and mark the jobs as done.

We therefore propose to add a small wizard to mark as done in batch, as it already exists for requeing jobs.

@coveralls

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 78.401% when pulling 4b7767d on CompassionCH:10.0 into 5c098fc on OCA:10.0.

@coveralls

coveralls commented Feb 22, 2018 •

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.1%) to 77.669% when pulling 54f96ea on CompassionCH:10.0 into 10b73c1 on OCA:10.0.

@ecino

ecino commented Apr 20, 2018

Copy link
Copy Markdown
Author

@guewen do you think this could be needed to all?

@yvaucher yvaucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense, and you can anyway requeue any jobs in done state, thus it gives you a better control.

Current work around are either to edit state in DB or to install mass_update module.

In batch changes I've also find myself doing a lot of eta edition. But that would be for an other feature.

Comment thread queue_job/views/queue_job_views.xml Outdated
</group>
<footer>
<button name="set_done" string="Set to done" type="object" class="oe_highlight"/>
or

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The or is the old fashion design of wizards in version 7.0 :)

@guewen guewen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. If you can remove the or in the wizard it'd be very nice.

@lmignon lmignon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ecino Thank you for this useful improvement. Can you remove the 'or' so we can merge your changes?

@ecino

ecino commented May 25, 2018

Copy link
Copy Markdown
Author

@lmignon @guewen Done!

@yvaucher
yvaucher merged commit 1017b1b into OCA:10.0 Jun 20, 2018
@ecino
ecino deleted the 10.0 branch June 22, 2018 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants