Repository navigation
[19.0][MIG] base_geoengine_demo: Migration to 19.0 - #490
weinni2000 wants to merge 86 commits into
Conversation
+ [FIX] in demo in order to have multipolygon samples
+ [IMP] menu name
+ [ADD] security
+ replace icons by nicer icons
geoengine_raster_layer: mapbox_type -> mapbox_id Merged some code from 6.1 branch
… actual requirement to be installable
…ding _unported suffix
The group element is required to properly display labels on the form + list all know contributors from git
This is a workaround of issue odoo/odoo#5618 Where non stored fields are not set into ir.models.fields table
As long wa do not have implemented a geodepends decorator Store values will never be refreshed
48c15b7 to
b430ed6
Compare
|
The following commit authors need to sign the Contributor License Agreement: |
7e37637 to
48c15b7
Compare
|
Hi @Tonow-c2c @sersanchus @yvaucher @kouffsamuel, your earlier commits are part of this migration, and the CLA check fails for thomas.nowicki@camptocamp.com, sersanchus@gmail.com, yannick.vaucher@camptocamp.com and samuel.kouff@hotmail.com. Could you sign at https://clabot.odoo-community.org/ (or have them added to your company's CLA)? Thanks! |
|
@etobella could you add CLA exceptions for these addresses? They are authors of earlier commits that this migration keeps, and they can't sign because the mail bounces:
Like the exceptions you added for OCA/account-invoicing#2507. Thanks! |
|
@weinni2000 I cannot add them as I don't know who is the people behind and if they signed a CLA. @sbidoul @StuartJMackintosh @OSevangelist what shall we do in this situations? Commits comes from version 6, previous to github. |
|
I believe there was an ECLA for savoirfairelinux? If so I think we can safely assume the contribs were covered by it. |
|
Great!! I did not found it in the OCA database when finding them, but savoirFaireLinux had one, so let's go!!! |
|
/ocabot rebase |
|
Congratulations, PR rebased to 19.0. |
|
can you ammend and push to reexecute the cla? |
Assisted-by: Claude Code (claude-opus-5-5)
b430ed6 to
85e6e2f
Compare
|
Amended and force-pushed; the CLA check re-ran. The Savoir-faire Linux authors are no longer listed. Still listed: yannick.vaucher@camptocamp.com, thomas.nowicki@camptocamp.com, nbessi@gmail.com and an empty author. Could you check whether the Camptocamp ECLA covers them, or add exceptions? Tests, runboat and pre-commit pass; 'Detect unreleased dependencies' fails because of the pending base_geoengine 19.0 migration (#465). |
|
In the case that there isn't evidence of ICLA, then the commit can't be
assumed as assigned to OCA. If truly abandoned, that doesn't create a
practical problem, but it does create the possibility that a company who
funded the individual could claim that it is theirs, or another
individual asserts copyright, and other potential edge-case risks. I
propose that we explore this at GWG and formulate a policy.
On 05/11/2026 10:55, Enric Tobella wrote:
*etobella* left a comment (OCA/geospatial#490)
<#490 (comment)>
@weinni2000 <https://github.com/weinni2000> I cannot add them as I
don't know who is the people behind and if they signed a CLA.
@sbidoul <https://github.com/sbidoul> @StuartJMackintosh
<https://github.com/StuartJMackintosh> @OSevangelist
<https://github.com/OSevangelist> what shall we do in this situations?
Commits comes from version 6, previous to github.
—
Reply to this email directly, view it on GitHub
<#490?email_source=notifications&email_token=AC2ZY3EDTRNAAZWBSJLYQ3T5XRE75A5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNRVGQ4TQNRTGM32M4TFMFZW63VHNVSW45DJN5XKKZLWMVXHJLDGN5XXIZLSL5RWY2LDNM#issuecomment-6654986337>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AC2ZY3FVLB5TGEBXSR4U7XD5XRE75AVCNFSNUABEKJSXA33TNF2G64TZHMZDAOBZGQYTIMB3JFZXG5LFHM3DCNBUHEYTEMBYHCQXMAQ>.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Stuart J Mackintosh
Business & digital technology consultant
Open Digital Consulting Co
Open Digital Consulting Co Logo
UK: +44 20 36 27 90 40
FR: +33 1 89 48 00 40
Email: ***@***.***
Web: https://opendigital.cc
IM: ***@***.***
|
|
I understand the importance of the CLA, but the current check can be frustrating for contributors, especially newcomers who have invested time in their first contribution and then find themselves blocked by something outside their control. For example, a small contribution made in 2013 by someone who has since left the company could prevent further development of an OCA module, even if that person still has a GitHub account. It would be helpful to have a practical way to resolve these cases without discouraging people from contributing. Could we temporarily disable the check while we: A) Email existing contributors and ask them to sign the CLA. B) Give them a reasonable timeframe to respond and reach a substantial level of participation. C) Agree on a clear policy for contributors who cannot sign or do not respond. Once those steps are in place, the check could be reinstated with a clearer path forward for everyone. |
|
@weinni2000 we understand your frustration, but the GWG meets in a weekly basis in order to solve this kind of issues. We were aware that this kind of problems could appear with the new CLA Bot, however, it gives a much better control and we can see real problems now. We will not delay the answer too much I hope. Meanwhile, we are trying to fix most of the PRs and we ask contributors to find the right people to ask for their signature. It can be a hard job right now, but it will be minimized in the future. |
|
@nbessi Maybe the email is yours and you can sign the CLA 🙏 About the https://github.com/OCA/geospatial/pull/490/changes/a4d5907bfd294f48e2d1e0834cab3dba7fc106cc.patch If I check in the 6 version, it seems that the commit was: https://github.com/OCA/geospatial/commit/92145c7c4f15649e048b910ebe64856dd7eaa79a.patch As you can see, the author was lost at some point in the migration. My proposal would be to get the commit ammend it and put the same original author (don't use WDYT? |
_check_the_point: loop over the records instead of readingself.the_point/self.zip_id(failed on multi-record writes), and useself.env._with a named placeholder (msgid updated in the existing translations)._compute_zip_id: clearzip_idwithFalseinstead of0, which gave the nonexistent recorddummy.zip(0,)when the point was removed.test-requirements.txt: installbase_geoenginefrom the 19.0 migration [19.0][MIG] base_geoengine: consolidated migration #465, which is not merged yet.UPGRADE.mdwork log of the 18.0 migration ([18.0][MIG] base_geoengine_demo #483).Depends on the 19.0 migration of base_geoengine (#465).
Migration changes only (diff after the pre-commit auto fixes): weinni2000#9
Migrated with odev.
Assisted-by: Claude Code (claude-opus-5-5)