Repository navigation
[18.0][MIG] website_geoengine: Migration to 18.0 - #474
Open
LINTOANTONY007 wants to merge 8 commits into
Open
LINTOANTONY007 wants to merge 8 commits into
LINTOANTONY007 wants to merge 8 commits into
Conversation
Currently translated at 100.0% (3 of 3 strings) Translation: geospatial-16.0/geospatial-16.0-website_geoengine Translate-URL: https://translation.odoo-community.org/projects/geospatial-16-0/geospatial-16-0-website_geoengine/it/
LINTOANTONY007
force-pushed
the
18.0-mig-website_geoengine
branch
3 times, most recently
from
August 6, 2026 09:19
17dc15a to
db1dd12
Compare
LINTOANTONY007
marked this pull request as draft
August 6, 2026 09:19
LINTOANTONY007
marked this pull request as ready for review
August 6, 2026 09:49
Author
|
@mymage , Can you please review this PR ? |
This was referenced Aug 11, 2026
Author
|
@tarteo , Can you review this PR? |
tarteo
reviewed
Sep 1, 2026
| tags = kw.get("tags", {}) | ||
| lang = kw.get("lang", "en_US") | ||
| maxResults = kw.get("maxResults", "200") | ||
| max_results = kw.get("maxResults", "200") |
Member
There was a problem hiding this comment.
Should maxResults key also be snake case, or is this somehow required?
Author
There was a problem hiding this comment.
if we need to make maxResults key snake case , then I need to make change in other module (Refer the line mentioned below). It is doable , simply because of this I just neglected it. If that is the case I can do it.
const args = {
tags: tags,
lang: this.lang,
maxResults: this.maxResults,
};
Member
There was a problem hiding this comment.
Ah clear, thanks for changing it though.
LINTOANTONY007
force-pushed
the
18.0-mig-website_geoengine
branch
2 times, most recently
from
September 3, 2026 06:56
6e51d54 to
7adc0b2
Compare
OCA-git-bot
added
mod:website_geoengine_store_locator
LINTOANTONY007
force-pushed
the
18.0-mig-website_geoengine
branch
3 times, most recently
from
October 5, 2026 09:02
d0b4d57 to
6aca184
Compare
tarteo
approved these changes
Oct 8, 2026
tarteo
reviewed
Oct 15, 2026
| "author": "Camptocamp, Odoo Community Association (OCA)", | ||
| "license": "AGPL-3", | ||
| "website": "https://github.com/OCA/geospatial", | ||
| "depends": ["base_geoengine", "website", "partner_store"], |
Member
There was a problem hiding this comment.
Oh my... I'm just realizing now that a dependence for base_geoengine is not needed at all in this module and the store locator module as both those modules never use any GIS related functionalities
LINTOANTONY007
force-pushed
the
18.0-mig-website_geoengine
branch
from
October 16, 2026 07:01
6aca184 to
16a5c67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is depended on OCA/partner-contact#2417
Once this PR is merged ,
opening_hoursinres.partnermodel is moved topartner-contact/partner_storemodule, asopening_hoursis a store related property field. So I think it must be in modulepartner_storeofpartner-contactrepo.Please Refer : OCA/partner-contact#2417