Skip to content

knightos-mkrom: unstable-2020-06-11 -> 1.0.2 - #97545

Merged
danieldk merged 2 commits into
NixOS:masterfrom
siraben:mkrom-1.0.2
Sep 10, 2020
Merged

knightos-mkrom: unstable-2020-06-11 -> 1.0.2#97545
danieldk merged 2 commits into
NixOS:masterfrom
siraben:mkrom-1.0.2

Conversation

@siraben

@siraben siraben commented Sep 9, 2020

Copy link
Copy Markdown
Member
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg Bot added 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 9, 2020
danieldk
danieldk suggested changes Sep 10, 2020
View reviewed changes
Comment thread pkgs/development/tools/knightos/mkrom/default.nix Resolved
@siraben Daniël de Kok
Update pkgs/development/tools/knightos/mkrom/default.nix
9101eed 
Co-authored-by: Daniël de Kok <me@github.danieldk.eu>
danieldk
danieldk approved these changes Sep 10, 2020
View reviewed changes

@danieldk danieldk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Result of nixpkgs-review pr 97545 1

1 package built:
  • knightos-mkrom

Binary works.

@danieldk
danieldk merged commit b2bd34d into NixOS:master Sep 10, 2020
@siraben
siraben deleted the mkrom-1.0.2 branch September 10, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@danieldk danieldk danieldk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siraben @danieldk