Skip to content

knightos-kcc: init at 4.0.0 - #95891

Merged
danieldk merged 1 commit into
NixOS:masterfrom
siraben:kcc-init
Aug 28, 2020
Merged

knightos-kcc: init at 4.0.0#95891
danieldk merged 1 commit into
NixOS:masterfrom
siraben:kcc-init

Conversation

@siraben

@siraben siraben commented Aug 21, 2020

Copy link
Copy Markdown
Member
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Aug 21, 2020
View reviewed changes

@danieldk danieldk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I have added some suggested improvements.

Comment thread pkgs/top-level/all-packages.nix Resolved
Comment thread pkgs/development/compilers/kcc/default.nix Resolved
Comment thread pkgs/development/compilers/kcc/default.nix Resolved
Comment thread pkgs/development/compilers/kcc/default.nix Resolved
@ofborg ofborg Bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Aug 21, 2020
@siraben
siraben force-pushed the kcc-init branch 2 times, most recently from 1c58ae1 to 72afb76 Compare August 22, 2020 02:25
@siraben siraben changed the title knightos_c: init at 4.0.0 knightos-kcc: init at 4.0.0 Aug 22, 2020
@siraben siraben mentioned this pull request Aug 22, 2020
Closed
@siraben
siraben requested a review from danieldk August 23, 2020 05:31
@siraben

siraben commented Aug 27, 2020

Copy link
Copy Markdown
Member Author

I think it's ready to merge.

danieldk
danieldk suggested changes Aug 27, 2020
View reviewed changes
Comment thread pkgs/development/compilers/kcc/default.nix Resolved
Comment thread pkgs/development/compilers/kcc/default.nix Resolved
@siraben
siraben requested a review from danieldk August 28, 2020 11:54
danieldk
danieldk approved these changes Aug 28, 2020
View reviewed changes

@danieldk danieldk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 95891 1

1 package built:
- knightos-kcc

@danieldk
danieldk merged commit 4eb9188 into NixOS:master Aug 28, 2020
@siraben
siraben deleted the kcc-init branch August 28, 2020 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@danieldk danieldk danieldk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@siraben @danieldk