Repository navigation
Rework natural gas pipelines schema - #546
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
=======================================
Coverage 71.65% 71.65%
=======================================
Files 82 82
Lines 8507 8507
Branches 922 922
=======================================
Hits 6096 6096
Misses 2237 2237
Partials 174 174
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR reworks the natural gas pipelines one-shot extraction plugin to use a decomposed, multi-axis “one row per requirement” schema, expanding the output model to capture richer requirement context while keeping compatibility with COMPASS’s schema-driven one-shot pipeline.
Changes:
- Updated
plugin_config.yamldiscovery queries/keywords and rewrote the extraction system prompt to teach the decomposition model and stricter scope rules. - Replaced the prior flat outputs schema with a decomposed row schema (WHAT / HOW MUCH / HOW BINDING / WHEN-WHERE + evidence), expanding features and adding richer evidence fields.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| compass/extraction/natural_gas_pipelines/plugin_config.yaml | Broadens discovery inputs and updates the extraction system prompt to align LLM behavior with the decomposed row model and scope rules. |
| compass/extraction/natural_gas_pipelines/natural_gas_pipelines_schema.json | Introduces the decomposed multi-axis output schema, expanded feature enum, and richer evidence/normalization guidance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ppinchuk
left a comment
There was a problem hiding this comment.
Cool ideas here! Could you please update to the latest COMPASS version and make sure your schema aligns with the new "ordinance_text" field that Rajendra added recently?
|
Is this ready for review? |
c70ef38 to
f12572f
Compare
@ppinchuk sorry for the delay, yes it is now ready for review |
Co-authored-by: bpulluta <115118857+bpulluta@users.noreply.github.com>
Bumps the codeql group with 2 updates: [github/codeql-action/init](https://github.com/github/codeql-action) and [github/codeql-action/analyze](https://github.com/github/codeql-action). Updates `github/codeql-action/init` from 4.38.3 to 4.39.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@24c5418...6f2ac81) Updates `github/codeql-action/analyze` from 4.38.3 to 4.39.0 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@24c5418...6f2ac81) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.39.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: codeql - dependency-name: github/codeql-action/analyze dependency-version: 4.39.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: codeql ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the other-actions group with 1 update: [prefix-dev/setup-pixi](https://github.com/prefix-dev/setup-pixi). Updates `prefix-dev/setup-pixi` from 0.11.0 to 0.11.2 - [Release notes](https://github.com/prefix-dev/setup-pixi/releases) - [Commits](prefix-dev/setup-pixi@9dabb60...ad1da64) --- updated-dependencies: - dependency-name: prefix-dev/setup-pixi dependency-version: 0.11.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: other-actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Summary
Reworks the natural gas pipelines one-shot extraction plugin so its schema captures decomposed, multi-axis requirement rows instead of the previous flat 5-field
outputs.This is an initial cut to continue developing and track changes.
Schema (
natural_gas_pipelines_schema.json)outputsrow is now decomposed on four axes:feature,specific_subject,applies_to,requirement_descriptionvalue,value_category,value_interpretation,units,range_low/range_highobligationconditionsource_verbatim,summary,section,notes,explanationpermit_approval; folded day/night into a singlenoisefeature +condition, and rear/side yard intoproperty lines distance+specific_subject.$qualitative_features(zoning districts,permit_approval) — previously missing, so every feature routed as quantitative.$scope,$core_principles, grouped$definitions,$instructions,$examples, and$qa_checklistfollowing the freshest sibling (oil_gas_wells) house style.Config (
plugin_config.yaml)heuristic_keywordskeys (house style).extraction_system_promptto teach the decomposition model (axes, one-row-per-requirement, most-restrictive rule, siting-focus exclusions).Validation
gpt-5.4, full search→download→collect→extract→CSV): produces the 25-column decomposed output; correctly extractednoise55 dBA (fully decomposed, withnoteson the absence of separate day/night limits) and twopermit_approvalrows (special permit, site plan approval), routed to the quant/qual CSVs correctly. Compared to the old flat output it dropped both false positives (a site-plan filing radius mislabeled as a setback; an exhaust muffler mislabeled as an enclosure).