Skip to content

Disable netlib testing - #550

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
ramakrishnap-nv:disable_netlib_testing
Oct 29, 2025
Merged

rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
ramakrishnap-nv:disable_netlib_testing

Conversation

@ramakrishnap-nv

@ramakrishnap-nv ramakrishnap-nv commented Oct 28, 2025 •

Copy link
Copy Markdown
Collaborator

Description

Issue

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

Summary by CodeRabbit

  • Chores
    • Disabled emps netlib dataset download functionality in benchmarking utilities.

@copy-pr-bot

copy-pr-bot Bot commented Oct 28, 2025

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test 28e44da

@coderabbitai

coderabbitai Bot commented Oct 28, 2025 •

Copy link
Copy Markdown

Walkthrough

The emps netlib dataset download and compilation functionality is disabled by adding an and False condition to the type equality check in the get_datasets utility, while maintaining existing extraction logic.

Changes

Cohort / File(s) Summary
Dataset download disabling
benchmarks/linear_programming/utils/get_datasets.py
Modified conditional from if type == "netlib": to if type == "netlib" and False:, disabling emps netlib dataset download and compilation steps

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the and False condition is intentional (not a debugging leftover or placeholder)
  • Confirm no dependent code relies on the emps netlib dataset download/compilation path
  • Check if documentation or comments need updating to reflect this behavioral change

Poem

🐰 A pause we take, the netlib sleeps,
While emps datasets gather digital sheep,
With and False we halt the tide,
Benchmarks rest, taking time inside! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "Disable netlib testing" directly and accurately describes the main change in the changeset. The modification adds a and False: condition to disable the emps netlib dataset download and compilation block in benchmarks/linear_programming/utils/get_datasets.py. The title is concise (3 words), clear, and uses descriptive language without vague terms or noise. A teammate scanning the repository history would immediately understand that this PR disables netlib testing functionality.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 53bf0fb and 28e44da.

📒 Files selected for processing (1)
  • benchmarks/linear_programming/utils/get_datasets.py (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ramakrishnap-nv ramakrishnap-nv added bug Something isn't working non-breaking Introduces a non-breaking change labels Oct 28, 2025
@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review October 28, 2025 21:39
@ramakrishnap-nv ramakrishnap-nv added this to the 25.12 milestone Oct 28, 2025

@Iroy30 Iroy30 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe there's a better way to do it but looks good for now

@hlinsen hlinsen mentioned this pull request Oct 29, 2025
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot
rapids-bot Bot merged commit 5879493 into NVIDIA:main Oct 29, 2025
176 of 177 checks passed
ramakrishnap-nv pushed a commit that referenced this pull request Oct 29, 2025
Hot fix with the following commits:
- #541
- #544
- #550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants