Skip to content

Include java-build in the PR test summary #1824

Open

Description

@ramakrishnap-nv

The "PR test summary (non-blocking)" job (ci/utils/pr_test_summary.py, wired up in .github/workflows/pr.yaml) only depends on and reports conda-cpp-tests, conda-python-tests, wheel-tests-cuopt, wheel-tests-cuopt-server, and test-self-hosted-server (_TEST_PREFIXES in the script, and the pr-test-summary job's needs: list). java-build isn't included, so it neither gates the summary nor shows up in it — the summary can post "all tests passed" while java-build is still running or has failed.

Possible fix

  • Add java-build to pr-test-summary's needs: list in .github/workflows/pr.yaml
  • Add a matching prefix to _TEST_PREFIXES in ci/utils/pr_test_summary.py
  • Note: _analyze_job_log only parses gtest ([ FAILED ]) and pytest (short test summary info) failure formats. A failed java-build job would still show up correctly as a failed job in the top-line counts, just without a per-test breakdown (JUnit/Surefire output isn't parsed) — that's an acceptable degrade, not a blocker, unless we also want per-test Java failures listed.

Context

Noticed while investigating #1820 / #1823: PR #1823's "PR test summary (non-blocking)" check passed while java-build / build was still in progress, which was confusing to reviewers since it looked like the whole PR was green.

Activity

  1. github-actions commented on Sep 19, 2026

    @github-actions

    🔔 Hi @anandhkb @hlinsen, this issue has had no activity for 21 days. Please update or let us know if it can be closed. Thank you!

    If this is an "epic" issue, then please add the "epic" label to this issue.
    If it is a PR and not ready for review, then please convert this to draft.
    If you just want to switch off this notification, then use the "skip inactivity reminder" label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions